New issue
Advanced search Search tips

Issue 785341 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

TimeTest.FromExploded_MinMax fails on macOS 10.13

Project Member Reported by asvitk...@chromium.org, Nov 15 2017

Issue description

TimeTest.FromExploded_MinMax fails on macOS 10.13.

See https://bugs.chromium.org/p/chromium/issues/detail?id=782033#c25


 
It fails in this code:

#if !defined(OS_ANDROID)
    // The dates earlier than |kExplodedMinYear| that don't work are OS version
    // dependent on Android.
    exploded.year--;
    EXPECT_FALSE(Time::FromUTCExploded(exploded, &parsed_time));
    EXPECT_TRUE(parsed_time.is_null());
#endif

This indicates that the following constant is no longer correct on 10.13:
  static constexpr int kExplodedMinYear = 1902;

That is, it means that in 10.13, the API is no longer limited to that minimum year. So, I think solution is to add OS_MAC to that ifdef and expand the comment mentioning that.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd7eeee732432fb9f4678b0363ff79da8bd5c85

commit 0fd7eeee732432fb9f4678b0363ff79da8bd5c85
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Thu Nov 16 20:25:27 2017

Fix TimeTest.FromExploded_MinMax on macOS 10.13.

BUG= 785341 

Change-Id: I23c09aba5b81386c6ebefacd4a51b9e4fc3c4f30
Reviewed-on: https://chromium-review.googlesource.com/774902
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517168}
[modify] https://crrev.com/0fd7eeee732432fb9f4678b0363ff79da8bd5c85/base/time/time_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment