New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 785337 link

Starred by 1 user
Status: Fixed
Owner:
█ hongjunchoi@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
kpaulhamus@chromium.org
█ piperc@chromium.org
kenrb@chromium.org
martinkr@google.com
engedy@chromium.org
ssoneff@google.com
jdoerrie@chromium.org
mknowles@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Change U2f request to handle concurrent device channel allocation

Project Member Reported by hongjunchoi@chromium.org, Nov 15 2017 
Currently, error is returned when packet from different channel is received during U2f HID device channel allocation. Change this behavior so that instead of returning error, message from different channel is simply disregarded.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a73f01daccc3d693dd05811c8c7ae082747efa

commit 98a73f01daccc3d693dd05811c8c7ae082747efa
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Wed Jan 03 19:23:40 2018

Change HID device behavior on channel allocation

Previously, all U2F HID device requests would fail if a packet for
different channel was received from hid device during channel
allocation. Changed this behavior so that packets for different channels
will be disregarded without causing request failure.

Bug:  785337 
Change-Id: Ibad715d4fd0024dd0d3ca35ac409e3d72ec0eb32
Reviewed-on: https://chromium-review.googlesource.com/770305
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526765}
[modify] https://crrev.com/98a73f01daccc3d693dd05811c8c7ae082747efa/device/u2f/BUILD.gn
[modify] https://crrev.com/98a73f01daccc3d693dd05811c8c7ae082747efa/device/u2f/fake_hid_impl_for_testing.cc
[modify] https://crrev.com/98a73f01daccc3d693dd05811c8c7ae082747efa/device/u2f/fake_hid_impl_for_testing.h
[modify] https://crrev.com/98a73f01daccc3d693dd05811c8c7ae082747efa/device/u2f/u2f_hid_device.cc
[modify] https://crrev.com/98a73f01daccc3d693dd05811c8c7ae082747efa/device/u2f/u2f_hid_device_unittest.cc

Comment 2 by hongjunchoi@chromium.org, Jan 23 2018

Status: Fixed (was: Started)
►

Sign in to add a comment