New issue
Advanced search Search tips

Issue 785329 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

pobfuzz: DrawTextBlobOp::Deserialize -> use-of-uninitialized-value in sk_fopen

Project Member Reported by ClusterFuzz, Nov 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6443611003813888

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sk_fopen
  mmap_filename
  SkStream::MakeFromFile
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=515053:515085

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6443611003813888

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Components: Internals>Skia

Comment 2 by mmoroz@chromium.org, Nov 15 2017

Labels: M-64
Assigning to vmpstr@ as https://chromium.googlesource.com/chromium/src/+/06970f10e5aab4e7b49196a335f9fbca1df5fa16 has been identified as a culprit CL.

Comment 3 by mmoroz@chromium.org, Nov 16 2017

Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Forgot to actually assign the issue.

Comment 4 by vmp...@chromium.org, Nov 16 2017

Cc: enne@chromium.org
Labels: Pri-2
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 16 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 16 2017

Labels: -Pri-2 Pri-1

Comment 7 by enne@chromium.org, Nov 16 2017

Labels: -Security_Impact-Head -ReleaseBlock-Stable -M-64 Security_Impact-None ReleaseBlock-NA
Summary: pobfuzz: DrawTextBlobOp::Deserialize -> use-of-uninitialized-value in sk_fopen (was: Use-of-uninitialized-value in sk_fopen)
This code is all behind a command line flag so is disabled by default.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 17 2017

Labels: -ReleaseBlock-NA
Project Member

Comment 9 by ClusterFuzz, Nov 22 2017

ClusterFuzz has detected this issue as fixed in range 518493:518517.

Detailed report: https://clusterfuzz.com/testcase?key=6443611003813888

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  sk_fopen
  mmap_filename
  SkStream::MakeFromFile
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=515053:515085
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=518493:518517

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6443611003813888

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6443611003813888 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 12 by enne@chromium.org, Nov 22 2017

Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Status: Assigned (was: Verified)
This was closed due to changes from https://chromium-review.googlesource.com/770522.  I think this is still a real issue that needs to be fixed, so I'm reopening this.  Please repro from older Chrome versions.
vmpstr@ do you think this crash can still be reached?
If you think it isn't reachable anymore, feel free to close.

I suspect if it were reachable, the fuzzer would have found a way to trigger it by now.

Comment 14 by enne@chromium.org, Apr 25 2018

Status: WontFix (was: Assigned)
I think we can WontFix this now.  The fuzzer hasn't refound it and we're going to remove this path.
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 2

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment