I'm seeing compile failures on Android arm64 on the Chromium Perf waterfall that first occurred in this run: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20arm64%20Builder/builds/164548 The only new CL in that run was https://chromium.googlesource.com/chromium/src/+/9e5c2bb47fab12af0f8e05726de234bd2b6d4680, which rolled the version of errorprone to 2.1.2. The compilation errors also mention errorprone, which seems to confirm that this is indeed the cause. CCing, wnwen@, the author of the CL Also CCing the two current Android sheriffs, nyquist@ and clamy@ I'm going to go ahead and revert the CL.
Link to compile failures here: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_arm64_Builder%2F164548%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
Woops, *actually* adding wnwen@, the CL author
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58ceae1a55b867cdae3db0a923605d44b34488c2 commit 58ceae1a55b867cdae3db0a923605d44b34488c2 Author: Charlie Andrews <charliea@chromium.org> Date: Wed Nov 15 17:45:40 2017 Revert "Android: Update errorprone to 2.1.2" This reverts commit 9e5c2bb47fab12af0f8e05726de234bd2b6d4680. This CL caused Android arm64 compile failures. NOTRY=true TBR=nyquist@chromium.org, yuweih@chromium.org, kapishnikov@chromium.org, agrieve@chromium.org Bug: 785324 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I235a28ff449f77fee3ab7f000773c4befdc032fa Reviewed-on: https://chromium-review.googlesource.com/771995 Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#516738} [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/DEPS [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/base/android/javatests/src/org/chromium/base/ObserverListTest.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/build/android/gyp/javac.py [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/build/android/lint/suppressions.xml [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/BUILD.gn [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/java/ChromeVersionConstants.java.version [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationItemView.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenu.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenuView.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationPresenter.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationView.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/remoting/android/java/src/org/chromium/chromoting/SessionConnector.java [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/third_party/errorprone/BUILD.gn [modify] https://crrev.com/58ceae1a55b867cdae3db0a923605d44b34488c2/third_party/errorprone/README.chromium
https://luci-milo.appspot.com/buildbot/chromium.perf/Android%20arm64%20Builder/164567 should be the first successful build.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6686c0001a1c308024788485783468485ddfce9d commit 6686c0001a1c308024788485783468485ddfce9d Author: Peter Wen <wnwen@chromium.org> Date: Wed Nov 15 21:51:48 2017 Reland "Android: Update errorprone to 2.1.2" Original CL: https://crrev.com/c/761318 Changes: - Suppress additional warning in ChromeVersionConstants BUG= 775031 , 785324 TBR=nyquist@chromium.org,yuweih@chromium.org,kapishnikov@chromium.org,agrieve@chromium.org Change-Id: I2c38e5fca25af5e6993477fcacf426df113fb2f0 Reviewed-on: https://chromium-review.googlesource.com/772000 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#516840} [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/DEPS [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/base/android/javatests/src/org/chromium/base/ObserverListTest.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/build/android/gyp/javac.py [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/build/android/lint/suppressions.xml [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/BUILD.gn [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/ChromeVersionConstants.java.version [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetNavigationItemView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationItemView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenu.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationMenuView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationPresenter.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/chrome/android/third_party/widget_bottomsheet_base/java/src/org/chromium/chrome/browser/widget/bottomsheet/base/BottomNavigationView.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/remoting/android/java/src/org/chromium/chromoting/SessionConnector.java [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/third_party/errorprone/BUILD.gn [modify] https://crrev.com/6686c0001a1c308024788485783468485ddfce9d/third_party/errorprone/README.chromium
Comment 1 by charliea@chromium.org
, Nov 15 2017