New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785314 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 780141



Sign in to add a comment

Confidence score is too low to alert code-review

Project Member Reported by st...@chromium.org, Nov 15 2017

Issue description

The culprit page actually shows 2 analyses, one with high and one with low confidence. both tests pointed to the same CL for introducing flakiness. It was the high confidence analysis that led to the culprit being notified, not the low confidence one.

https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTUxODJkY2NmM2Y0OTQ3MWI5NzYxZTYwMThhYzlkMDk3N2ExM2NlNww

So in this case Findit's behavior is actually correct. I'm thinking we show confidence score on the flake culprit page too to make it clear which test is actually more likely impacted by the change
Ideas (can be implemented independently):
1. Introduce confidence score to flake_culprit page to help differentiate between false positives and true culprits
2. In the dashboard, make it more clear which analysis triggered the code review notification, since currently they are all either "True/False" for notified. Can also have a 3rd value for "Already Done" or another string indicating that another analysis already notified the same code review
Blocking: 780141
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6f8050b96d895ba33acb00fd0449ab41168b72f3

commit 6f8050b96d895ba33acb00fd0449ab41168b72f3
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Nov 17 17:29:39 2017

[Findit] Flake Analyzer - Link flake culprit pages to dashboard

The culprit notified True/False fields should now include links to the
flake culprit pages to easily view all analyses that had the same culprit.

Bug:  785314 
Change-Id: Iedbe9e50bc4bb077878a0afb8c9d4f13a1ab8ed2
Reviewed-on: https://chromium-review.googlesource.com/775656
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/6f8050b96d895ba33acb00fd0449ab41168b72f3/appengine/findit/templates/flake/dashboard.html
[modify] https://crrev.com/6f8050b96d895ba33acb00fd0449ab41168b72f3/appengine/findit/model/base_suspected_cl.py

Status: Fixed (was: Assigned)

Sign in to add a comment