Confidence score is too low to alert code-review |
|||
Issue descriptionPage URL: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVypwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJxY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjQ2MjgvYnJvd3Nlcl90ZXN0cy9URzlqWVd4T1ZGQktZWFpoYzJOeWFYQjBWR1Z6ZEM1VGFXMXdiR1ZLWVhaaGMyTnlhWEIwVkdWemRITT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Description: In this case it is a false positive. Is it because that we have heuristic result and force commit-level analysis?
,
Nov 15 2017
Ideas (can be implemented independently): 1. Introduce confidence score to flake_culprit page to help differentiate between false positives and true culprits 2. In the dashboard, make it more clear which analysis triggered the code review notification, since currently they are all either "True/False" for notified. Can also have a 3rd value for "Already Done" or another string indicating that another analysis already notified the same code review
,
Nov 16 2017
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/cc8c14881d5f8290d2b7f74307400888a258ac08 commit cc8c14881d5f8290d2b7f74307400888a258ac08 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Thu Nov 16 21:26:56 2017 [Findit] Flake Analyzer - Add confidence score to flake culprit page Bug: 785314 Change-Id: I4175ae7e8aeb8dd00f8a26c1b5a52b118087462b Reviewed-on: https://chromium-review.googlesource.com/775559 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/cc8c14881d5f8290d2b7f74307400888a258ac08/appengine/findit/handlers/flake/test/flake_culprit_test.py [modify] https://crrev.com/cc8c14881d5f8290d2b7f74307400888a258ac08/appengine/findit/templates/flake/flake-culprit.html [modify] https://crrev.com/cc8c14881d5f8290d2b7f74307400888a258ac08/appengine/findit/handlers/flake/flake_culprit.py
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6f8050b96d895ba33acb00fd0449ab41168b72f3 commit 6f8050b96d895ba33acb00fd0449ab41168b72f3 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Nov 17 17:29:39 2017 [Findit] Flake Analyzer - Link flake culprit pages to dashboard The culprit notified True/False fields should now include links to the flake culprit pages to easily view all analyses that had the same culprit. Bug: 785314 Change-Id: Iedbe9e50bc4bb077878a0afb8c9d4f13a1ab8ed2 Reviewed-on: https://chromium-review.googlesource.com/775656 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/6f8050b96d895ba33acb00fd0449ab41168b72f3/appengine/findit/templates/flake/dashboard.html [modify] https://crrev.com/6f8050b96d895ba33acb00fd0449ab41168b72f3/appengine/findit/model/base_suspected_cl.py
,
Dec 1 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lijeffrey@chromium.org
, Nov 15 2017