New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785302 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 783946



Sign in to add a comment

[Findit] Flake analyzer - use yield for recursive flake try job sub pipelines

Project Member Reported by lijeffrey@chromium.org, Nov 15 2017

Issue description

Currently recursive flake try job pipeline spawns separate pipelines for next commit position and so on, making it difficult to trace when something goes wrong.

Use yield instead so the pipelines can be viewed in the status when debugging
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9530714a4cc2c1e280f97d41f62b09084dbdebd7

commit 9530714a4cc2c1e280f97d41f62b09084dbdebd7
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Nov 15 22:41:31 2017

[Findit] Flake Analyzer - Use yield when starting pipelines with delay

No real functional change. Currently several analyses are failing with
no real useful logs or information despite acctually making it to
completion. By using yield instead of .start() the pipeline path tree is
preserved making it easier to investigate.

Bug:  785302 
Change-Id: Id960f9277651a08263f489f45ee8391927a374c1
Reviewed-on: https://chromium-review.googlesource.com/772825
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/9530714a4cc2c1e280f97d41f62b09084dbdebd7/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[modify] https://crrev.com/9530714a4cc2c1e280f97d41f62b09084dbdebd7/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py

Status: Fixed (was: Assigned)
Blocking: 783946

Sign in to add a comment