Hi dullweber@ dominickn@, you two seem to know the tests the most, could you please help take a look?

thanks

https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/20370

Looks like data from QuotaManager is missing:

[ RUN      ] ImportantSitesUsageCounterTest.PopulateUsage
../../chrome/browser/engagement/important_sites_usage_counter_unittest.cc:152: Failure
      Expected: 1 + 2 + 4 + 16
      Which is: 23
To be equal to: domain_info()[0].usage
      Which is: 16
[  FAILED  ] ImportantSitesUsageCounterTest.PopulateUsage (37 ms)

This change from 10 hours ago is probably issue: https://chromium-review.googlesource.com/c/chromium/src/+/765614

That's what I suspected too. I am going to revert this CL for now.

Thanks

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5594923b09f14a45a3ce1ebe05646d865bc54a5d

commit 5594923b09f14a45a3ce1ebe05646d865bc54a5d
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Nov 15 17:22:27 2017

Revert "Specify REAL_IO_THREAD in the TestBrowserThreadBundle for ImportantSitesUsageCounterTest."

This reverts commit afac65b656d03ff4a85c4aca3f3537d906d5490a.

Reason for revert: Suspect causing failure for ImportantSitesUsageCounterTest.PopulateUsage on Mac10.11 and Mac10.12

Original change's description:
> Specify REAL_IO_THREAD in the TestBrowserThreadBundle for ImportantSitesUsageCounterTest.
> 
> BUG= 748747 
> 
> Change-Id: I890c1dd6596decb6266f2be7dd65485be0ba8139
> Reviewed-on: https://chromium-review.googlesource.com/765614
> Reviewed-by: Ben Wells <benwells@chromium.org>
> Commit-Queue: Dominick Ng <dominickn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516597}

TBR=benwells@chromium.org,dominickn@chromium.org,btolsch@chromium.org

Change-Id: I76373692ba14421b6bed4c61088d4bdc6d7f0aea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  785296 
Reviewed-on: https://chromium-review.googlesource.com/772110
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516730}
[modify] https://crrev.com/5594923b09f14a45a3ce1ebe05646d865bc54a5d/chrome/browser/engagement/important_sites_usage_counter_unittest.cc