New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785295 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Media Controls CTR metrics are broken for some fields

Project Member Reported by mlamouri@chromium.org, Nov 15 2017

Issue description

OverlayCastButton, OverlayPlayButtond and ClosedCaptionButton seem to have off values.

This is a very late follow-up from comments from dahlke@.
 
FWIW, the OverlayPlayButton is rarely displayed according to our metrics. I think this is a side effect of us recording the metrics only when the metadata are loaded which means that the button may be visible more often and the click ratio will be exaggerated.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fdc60f92edd50012f489ba52f18bcdad26b3794

commit 6fdc60f92edd50012f489ba52f18bcdad26b3794
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Nov 15 19:26:31 2017

Media Controls: fix issues with CTR metrics calculation.

There are 3 fixes:
 - Record visibility of CastOverlayButton;
 - Fix type in ClosedCaptionButton string;
 - Record clicks for PlayOverlayButton.

Bug:  785295 
Change-Id: I2b57bbef248666aaa3683cd14907043ecf31aea3
Reviewed-on: https://chromium-review.googlesource.com/771795
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516781}
[modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp
[modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp

Status: Fixed (was: Started)

Sign in to add a comment