Media Controls CTR metrics are broken for some fields |
||
Issue descriptionOverlayCastButton, OverlayPlayButtond and ClosedCaptionButton seem to have off values. This is a very late follow-up from comments from dahlke@.
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fdc60f92edd50012f489ba52f18bcdad26b3794 commit 6fdc60f92edd50012f489ba52f18bcdad26b3794 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Wed Nov 15 19:26:31 2017 Media Controls: fix issues with CTR metrics calculation. There are 3 fixes: - Record visibility of CastOverlayButton; - Fix type in ClosedCaptionButton string; - Record clicks for PlayOverlayButton. Bug: 785295 Change-Id: I2b57bbef248666aaa3683cd14907043ecf31aea3 Reviewed-on: https://chromium-review.googlesource.com/771795 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#516781} [modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/6fdc60f92edd50012f489ba52f18bcdad26b3794/third_party/WebKit/Source/modules/media_controls/elements/MediaControlToggleClosedCaptionsButtonElement.cpp
,
Nov 15 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Nov 15 2017