New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785288 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Restarting Chrome breaks Sync and logs me out of every site

Project Member Reported by a...@chromium.org, Nov 15 2017

Issue description

64.0.3269.0 canary

Starting from a few canaries ago, every time I restart Chrome it breaks my sync token and logs me out of every single site I'm logged into. This is new behavior and a major regression.

 
Screen Shot 2017-11-15 at 10.45.47 AM.png
147 KB View Download

Comment 1 by s...@chromium.org, Nov 15 2017

Components: Services>SignIn

Comment 2 by a...@chromium.org, Nov 15 2017

Status: Fixed (was: Untriaged)
A reboot seems to have fixed everything.

On email the discussion yielded "this is a failure to decrypt". A rogue app spun out of control and ate all my memory. I killed it, but it must have left the keychain broken.

Thanks for your help.

Comment 3 by a...@chromium.org, Nov 15 2017

Status: WontFix (was: Fixed)
Cc: thestig@chromium.org cfroussios@chromium.org
So Mac Keychain getting wedged makes Chrome behave poorly.

- Do we want to file a bug with Apple? System services should be reliant to rouge apps eating all the memory.
- Do we want to look into testing for Mac Keychain sanity in Chrome to guard against this?

Comment 5 by shrike@chromium.org, Nov 15 2017

Cc: mark@chromium.org rsesek@chromium.org
e.g. With Chromium on Mac, if I deny the keychain access request, then components/os_crypt/keychain_password_mac.mm line 76

OSSTATUS_DLOG(ERROR, error) << "Keychain lookup failed";

prints out:

Keychain lookup failed: Error Domain=NSOSStatusErrorDomain Code=-128 "userCanceledErr" (-128)

I wonder what that would output when Keychain is in a bad state.

Comment 7 by mark@chromium.org, Nov 15 2017

Can this be readily reproduced with a memory hog running alongside Chrome?

Comment 8 by a...@chromium.org, Nov 16 2017

I haven't tried to repro it. My recollection is that the rogue app ran things so far out of memory that the "you have no memory" dialog appeared. In addition, this wasn't the only time this memory thing happened but this was the only time that the keychain issues happened.
Ran into this myself, seeing the "failure to decrypt" message in the logs. A computer restart sorted everything out. :)

Sign in to add a comment