New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785269 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 779475
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.7% regression in system_health.memory_desktop at 511501:511600

Project Member Reported by bokan@chromium.org, Nov 15 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=785269

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=53c8bc26d3d351ff2452b2a3844cb8d81565a29c8628738e6c95d9decadf99f6


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12e1faf9f80000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

Cc: creis@chromium.org alex...@chromium.org holte@chromium.org
Owner: alex...@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12e1faf9f80000

Add field trial testing config for sign-in process isolation.
By alexmos@chromium.org ยท Wed Oct 25 21:26:19 2017
chromium @ 9cf0ac139cc65890b9e036f704040c8da332d6e3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

Mergedinto: 779475
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alex Moshchuk
  Commit : 9cf0ac139cc65890b9e036f704040c8da332d6e3
  Date   : Wed Oct 25 21:26:19 2017
  Subject: Add field trial testing config for sign-in process isolation.

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_media/load_media_dailymotion
  Change       : 12.22% | 21458538.6667 -> 24081068.0

Revision             Result                   N
chromium@511500      21458539 +- 856460       6      good
chromium@511550      21576440 +- 872287       6      good
chromium@511575      21532503 +- 1438067      6      good
chromium@511588      22060867 +- 1257795      6      good
chromium@511591      21521833 +- 1424218      6      good
chromium@511593      22470735 +- 1117394      6      good
chromium@511594      24571216 +- 2165394      6      bad       <--
chromium@511600      24081068 +- 1433116      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.dailymotion system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962849754880073152


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 15 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Alex Moshchuk
  Commit : 9cf0ac139cc65890b9e036f704040c8da332d6e3
  Date   : Wed Oct 25 21:26:19 2017
  Subject: Add field trial testing config for sign-in process isolation.

Bisect Details
  Configuration: winx64ati_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_media/load_media_dailymotion
  Change       : 9.44% | 22053455.1111 -> 24134427.5556

Revision             Result                   N
chromium@511500      22053455 +- 2591469      9      good
chromium@511550      22358712 +- 1504187      6      good
chromium@511575      21176836 +- 1719378      6      good
chromium@511588      21896435 +- 1503652      6      good
chromium@511591      22050982 +- 2561115      9      good
chromium@511593      21669332 +- 2937677      9      good
chromium@511594      23972079 +- 1302012      6      bad       <--
chromium@511600      24134428 +- 2451628      9      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.dailymotion system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962849785517211168


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment