Issue metadata
Sign in to add a comment
|
App crashes on enabling “toolbar-snapshot-animation” from chrome://flags |
||||||||||||||||||||||||
Issue descriptionApp Version: 64.0.3269.0 canary iOS Version:10.3.3, 11.1.1 Device : iPhones Steps to reproduce : 1. Launch chrome. 2. Go to chrome://flags 3. Enable “toolbar-snapshot-animation” 4. force quit the app and Relaunch chrome. 5. Goto any site say facebook.com Observed results: App Crashes Note : Works fine in 64.0.3267.0 canary Expected results: App should not crash. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: NA Bug reproducible on current stable build (App Version, iOS Version): NA, New UI Implementation in M64 Bug reproducible on the current beta channel build (App Version, iOS Version): NA, New UI Implementation in M64 Type-bug-regression? NA, New UI Implementation in M64 Link to Video : https://drive.google.com/a/google.com/file/d/1zKEZFIyKFVYMUDbeTt3hrpDfgbfWqZa2/view?usp=sharing Crash log : https://crash.corp.google.com/browse?stbtiq=32d2d23819bd4001&sql_dialect=googlesql Stack Trace : Thread 0 (id: 1027) CRASHED [EXC_SOFTWARE / UNCAUGHT_NS_EXCEPTION @ 0x1c817b3d ] MAGIC SIGNATURE THREAD Stack Quality81%Show frame trust levels 0x1c817b3d (CoreFoundation + 0x000fab3d ) __exceptionPreprocess 0x1ba9f065 (libobjc.A.dylib + 0x00007065 ) objc_exception_throw 0x1c81cfcf (CoreFoundation + 0x000fffcf ) -[NSObject(NSObject) doesNotRecognizeSelector:] 0x1c81b0c1 (CoreFoundation + 0x000fe0c1 ) ___forwarding___ 0x1c743dc6 (CoreFoundation + 0x00026dc6 ) _CF_forwarding_prep_0 0x002116fd (Chrome -web_toolbar_controller.mm:1760 ) -[WebToolbarController contractOmnibox] 0x0020c83d (Chrome -web_toolbar_controller.mm ) -[WebToolbarController locationBarHasResignedFirstResponder] 0x0021acf7 (Chrome -location_bar_controller_impl.mm:271 ) LocationBarControllerImpl::OnKillFocus() 0x002289f7 (Chrome -omnibox_view_ios.mm:402 ) OmniboxViewIOS::OnDidEndEditing() 0x002288ed (Chrome -omnibox_view_ios.mm:137 ) -[AutocompleteTextFieldDelegate textFieldDidEndEditing:] 0x21b743ef (UIKit + 0x001393ef ) -[UITextField _resignFirstResponder] 0x21b4c443 (UIKit + 0x00111443 ) -[UIResponder _finishResignFirstResponder] 0x2241f455 (UIKit + 0x009e4455 ) -[UITextField _finishResignFirstResponder] 0x21af0437 (UIKit + 0x000b5437 ) -[UIResponder resignFirstResponder] 0x21b74075 (UIKit + 0x00139075 ) -[UITextField resignFirstResponder] 0x0022ae67 (Chrome -omnibox_view_ios.mm:790 ) OmniboxViewIOS::HideKeyboardAndEndEditing() 0x0020cc0b (Chrome -web_toolbar_controller.mm:956 ) -[WebToolbarController cancelOmniboxEdit] 0x0020c4c1 (Chrome -web_toolbar_controller.mm:887 ) -[WebToolbarController loadGURLFromLocationBar:transition:] 0x0021a50f (Chrome -location_bar_controller_impl.mm:205 ) LocationBarControllerImpl::OnAutocompleteAccept(GURL const&, WindowOpenDisposition, ui::PageTransition, AutocompleteMatchType::Type) 0x00e54b61 (Chrome -omnibox_edit_model.cc:711 ) OmniboxEditModel::OpenMatch(AutocompleteMatch, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) 0x00e59455 (Chrome -omnibox_view.cc:91 ) OmniboxView::OpenMatch(AutocompleteMatch const&, WindowOpenDisposition, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, unsigned long) 0x00221c27 (Chrome -omnibox_popup_view_ios.mm:157 ) OmniboxPopupViewIOS::OnMatchSelected(AutocompleteMatch const&, unsigned long) 0x0021b533 (Chrome -omnibox_popup_mediator.mm:81 ) -[OmniboxPopupMediator autocompleteResultConsumer:didSelectRow:] 0x00220c2d (Chrome -omnibox_popup_view_controller.mm:448 ) -[OmniboxPopupViewController tableView:didSelectRowAtIndexPath:] 0x21b70bbd (UIKit + 0x00135bbd ) -[UITableView _selectRowAtIndexPath:animated:scrollPosition:notifyDelegate:] 0x21c1cb63 (UIKit + 0x001e1b63 ) -[UITableView _userSelectRowAtPendingSelectionIndexPath:] 0x21cc8981 (UIKit + 0x0028d981 ) _runAfterCACommitDeferredBlocks 0x21cbbc91 (UIKit + 0x00280c91 ) _cleanUpAfterCAFlushAndRunDeferredBlocks 0x21a3d8bb (UIKit + 0x000028bb ) _afterCACommitHandler 0x1c7d3801 (CoreFoundation + 0x000b6801 ) __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ 0x1c7d1a53 (CoreFoundation + 0x000b4a53 ) __CFRunLoopDoObservers 0x1c7d2015 (CoreFoundation + 0x000b5015 ) __CFRunLoopRun 0x1c7251ad (CoreFoundation + 0x000081ad ) CFRunLoopRunSpecific 0x1c724fcf (CoreFoundation + 0x00007fcf ) CFRunLoopRunInMode 0x1decfb3f (GraphicsServices + 0x00009b3f ) GSEventRunModal 0x21aada51 (UIKit + 0x00072a51 ) UIApplicationMain 0x0000e5c5 (Chrome -chrome_exe_main.mm:55 ) main 0x1bf124e9 (libdyld.dylib + 0x000034e9 ) start
,
Nov 28 2017
@gambard - Instead of closing this as WontFix now, can you please keep this open until it is actually fixed and should no longer be occurring, to avoid confusion of how long we should continue to ignore this crash?
,
Nov 29 2017
Sure, sorry. Assigning to sczs@ as you introduced the flag.
,
Nov 29 2017
Since we will be re-writing most of the toolbar instead of refactoring the old one this flag will most certainly will be removed. Just to be sure, we are talking about "property-animation-toolbar" right? Because I can't find a “toolbar-snapshot-animation” flag.
,
Dec 6 2017
Since this flag will be removed, I'll merge this issue into 785540
,
Dec 7 2017
"toolbar-snapshot-animation" flag is used to enable "Toolbar animation when entering/leaving the StackView" as "toolbar-snapshot-animation" flag in no more present in chrome://flags, I have enabled "property-animation-toolbar". Yes the crash is related to "property-animation-toolbar".
,
Dec 12 2017
Verified on chrome canary version 65.0.3292.0, property-animations-toolbar flag is not available in chrome://flags. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by gambard@chromium.org
, Nov 15 2017