2 different selections (keyboard and mouse) for the hoverbutton |
||||||||||||
Issue descriptionWith the HoverButton, there are now 2 different kind of selections in the profile chooser menu. One selection is based on the keyboard, one is based on the mouse. It looks weird. Before, the selection from the keyboard was override by the mouse as soon as the mouse was moving over the profile chooser menu. I tried the issue on macOS and Linux.
,
Nov 15 2017
,
Nov 15 2017
,
Nov 15 2017
If we are happy with the visual representation for Keyboard-focus, we can probably fix this and Issue 784684 at the same time just by requesting focus on hover.
,
Nov 15 2017
,
Nov 15 2017
FWIW, the visual representation for keyboard-focus LGTM, but I'd let Alan comment
,
Nov 16 2017
Issue 785164 has been merged into this issue.
,
Nov 16 2017
WIP here: https://chromium-review.googlesource.com/c/chromium/src/+/773319
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c commit 2dd7f6c07aa8da74798ccdee953cc33e8d484b2c Author: Patti <patricialor@chromium.org> Date: Thu Nov 16 05:21:19 2017 Profile Chooser/Views: Only one HoverButton can be highlighted at a time. When mouse hovering and tabbing through the buttons in the ProfileChooserView at the same time, it is possible to get two different buttons to be highlighted. Prevent this by requesting focus on hover, then highlighting on focus only. This prevents confusion about which item actually has keyboard focus. This has the desired side effect of making the fade-in animation duration instant as well ( crbug.com/784684 ). Bug: 785164 , 785262 , 784684 Change-Id: Id379f2c373307f2c49dbce58cf40d3d61f9f324e Reviewed-on: https://chromium-review.googlesource.com/773319 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#516996} [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.cc [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.h
,
Nov 16 2017
,
Nov 17 2017
Tested the issue on Windows-7, Ubuntu 14.04 and Mac OS 10.12.6 using chrome latest Canary M64-64.0.3271.0 by following steps mentioned in the issue:785164 & original comment. Observed that focus and pages are displaying as expected. Hence adding TE-Verified label. Please find the screen cast for reference. Thank you! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by jlebel@chromium.org
, Nov 15 2017