Because 'name' is hard coded to the task name, it's impossible to see the tag 'name' on Swarming tasks as a column.
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/0b386cd3643a40455bb168ec91b7007aaa28ad2b commit 0b386cd3643a40455bb168ec91b7007aaa28ad2b Author: Kevin Lubick <kjlubick@google.com> Date: Fri Mar 16 19:03:40 2018 make tags explicit Bug: 785261 Change-Id: I596407119a73ab4537892b4e367d4cb7187ca755 Reviewed-on: https://chromium-review.googlesource.com/966928 Commit-Queue: Kevin Lubick <kjlubick@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/0b386cd3643a40455bb168ec91b7007aaa28ad2b/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/0b386cd3643a40455bb168ec91b7007aaa28ad2b/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/0b386cd3643a40455bb168ec91b7007aaa28ad2b/appengine/swarming/ui/res/imp/tasklist/task-list-data.html [modify] https://crrev.com/0b386cd3643a40455bb168ec91b7007aaa28ad2b/appengine/swarming/ui/res/imp/tasklist/task-list.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/5abb38c425e9e817a5d0f903a17f39e1b67c951d commit 5abb38c425e9e817a5d0f903a17f39e1b67c951d Author: Kevin Lubick <kjlubick@google.com> Date: Fri Mar 16 20:09:47 2018 Switch to tag- prefix Colon has a very distinct meaning and having "tag:" broke many things including sorting and filtering. tag- should be just as insightful. Bug: 785261 Change-Id: If85650a73d34a82c232cecc4dc9b1acded827228 Reviewed-on: https://chromium-review.googlesource.com/967146 Reviewed-by: Kevin Lubick <kjlubick@chromium.org> Reviewed-by: Ben Wagner <benjaminwagner@chromium.org> [modify] https://crrev.com/5abb38c425e9e817a5d0f903a17f39e1b67c951d/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/5abb38c425e9e817a5d0f903a17f39e1b67c951d/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/5abb38c425e9e817a5d0f903a17f39e1b67c951d/appengine/swarming/ui/res/imp/tasklist/task-list-data.html [modify] https://crrev.com/5abb38c425e9e817a5d0f903a17f39e1b67c951d/appengine/swarming/ui/res/imp/tasklist/task-list.html
This is now life
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/24d9b1e53d0f7f2e47390860481fe1a58d8242c1 commit 24d9b1e53d0f7f2e47390860481fe1a58d8242c1 Author: Kevin Lubick <kjlubick@google.com> Date: Mon Mar 19 17:11:08 2018 Change to -tag suffix Also de-duplicate dimensions and -tags BUG:785261 Change-Id: I08e43801e5b89ed8ac8bd72b97e76e15c7801722 Reviewed-on: https://chromium-review.googlesource.com/968707 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/botlist/bot-filters.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/tasklist/task-list-data.html [modify] https://crrev.com/24d9b1e53d0f7f2e47390860481fe1a58d8242c1/appengine/swarming/ui/res/imp/tasklist/task-list.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3 commit 9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Fri Mar 23 16:59:51 2018 Revert "Change to -tag suffix" This reverts commit 24d9b1e53d0f7f2e47390860481fe1a58d8242c1. Reason for revert: It's impossible to filter by some tags now. As I'm doing unrelated tricky refactoring, it may be hard to go back to older revisions and Kevin is OOO. This can be reapplied with fix later. Bug:785261, 824928 Original change's description: > Change to -tag suffix > > Also de-duplicate dimensions and -tags > > BUG:785261 > > Change-Id: I08e43801e5b89ed8ac8bd72b97e76e15c7801722 > Reviewed-on: https://chromium-review.googlesource.com/968707 > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Commit-Queue: Kevin Lubick <kjlubick@chromium.org> TBR=maruel@chromium.org,kjlubick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4e0b5e72148089b8aad6ab8c4f8c32be5bbf2935 Reviewed-on: https://chromium-review.googlesource.com/977864 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/botlist/bot-filters.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-list-data.html [modify] https://crrev.com/9aff2e7d9b533beb612e69d685bf0b7f1a8ea9c3/appengine/swarming/ui/res/imp/tasklist/task-list.html
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939 commit 5ae95288441ee0d2b2ffcb0c67dded76f4ae5939 Author: Kevin Lubick <kjlubick@google.com> Date: Wed Apr 04 12:13:39 2018 Reland 24d9b1e53d0f7f2e47390860481fe1a58d8242c1 Change to -tag suffix Also de-duplicate dimensions and -tags Bug: 785261 , 824928 Change-Id: Ief86435b127cc8e38add3f615648991d37223456 Reviewed-on: https://chromium-review.googlesource.com/993422 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/build/js/js.js [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/botlist/bot-filters.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-filters.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-list-data.html [modify] https://crrev.com/5ae95288441ee0d2b2ffcb0c67dded76f4ae5939/appengine/swarming/ui/res/imp/tasklist/task-list.html
Comment 1 by kjlubick@google.com
, Mar 16 2018Owner: kjlubick@chromium.org
Status: Started (was: Available)