New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785245 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Reticle sorting broken on overlay elements

Project Member Reported by vollick@chromium.org, Nov 15 2017

Issue description

The reticle is currently always sorted into the "foreground" draw phase. The result is that it if it is meant to be drawn atop a foreground element, it will be sorted behind it.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/684bd3e81b3455be86aeb2b4a8bede4f7840bbab

commit 684bd3e81b3455be86aeb2b4a8bede4f7840bbab
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Nov 15 14:56:38 2017

[vr] Fix reticle sorting for elements in different draw phases

In my CL to fix reticle sorting, I did not update the draw phase of the
reticle when I inserted into the lists of elements vended by the UiScene
https://chromium-review.googlesource.com/c/chromium/src/+/749741

The consequence is that, although we returned the reticle in the right
spot from UiScene, the UiRenderer would then promptly sort it into the
wrong position when it sorted out draw phases.

Bug:  785245 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I36fb157257d079c88b556d4383fae75ab48efb65
Reviewed-on: https://chromium-review.googlesource.com/771533
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516697}
[modify] https://crrev.com/684bd3e81b3455be86aeb2b4a8bede4f7840bbab/chrome/browser/vr/ui_renderer_unittest.cc
[modify] https://crrev.com/684bd3e81b3455be86aeb2b4a8bede4f7840bbab/chrome/browser/vr/ui_scene.cc

Status: Fixed (was: Started)
Labels: M-64 Test-Complete

Sign in to add a comment