Issue metadata
Sign in to add a comment
|
Wrong coordinates of the animated CSS offset-path.
Reported by
aga...@gmail.com,
Nov 15 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: Demo: https://jsbin.com/melejew/5/edit?html,css,output. What is the expected behavior? The green circle should overlap the red circle. What went wrong? * In Win with devicePixelRatio 1 everything works correctly. * In Win with devicePixelRatio 2 the green circle does not overlap the red circle. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 62.0.3202.94 Channel: stable OS Version: 10.0 Flash Version: In Mac OS this problem was not noticed (both with Retina-display, and without). Parental bug: https://bugs.chromium.org/p/chromium/issues/detail?id=654664.
,
Nov 15 2017
,
Nov 16 2017
Able to reproduce the issue on Window 10 highdpi machine using chrome reported version #62.0.3202.94 and latest canary #64.0.3269.3. Bisect Information: ===================== Good build: 55.0.2866.0 Revision(419628) Bad Build : 55.0.2867.0 Revision(419930) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/8e45c7b614dab5a62f0425e0752567b59a4035d5..ba9dc4f32ee4a0a29ab99be8274e2605998d14b1 From the above change log suspecting below change Review url: https://codereview.chromium.org/2241993002 ericwilligers@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Nov 16 2017
,
Dec 6 2017
,
Dec 29 2017
Not a regression. The identified CL is when motion-path was renamed to offset-path.
,
Jan 10 2018
When we calculate the translation from PointAndNormalAtLength, we need to adjust for zoom:
float zoom = EffectiveZoom();
motion_path.GetPath().PointAndNormalAtLength(computed_distance, point,
angle);
point.SetX(point.X() * zoom);
point.SetY(point.Y() * zoom);
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa commit c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa Author: Eric Willigers <ericwilligers@chromium.org> Date: Thu Jan 11 04:26:09 2018 CSS Motion Path: Allow for zoom and High DPI The distances expressed in path strings (and methods like PointAndNormalAtLength) do not take zoom or high DPI into account. On Window 10 highdpi machines, motion path elements were being placed incorrectly. BUG= 785219 Change-Id: I4d17cb92d8ba6c6fcfa3ae5f0c3f294d304e6740 Reviewed-on: https://chromium-review.googlesource.com/860964 Reviewed-by: nainar <nainar@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#528559} [add] https://crrev.com/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa/third_party/WebKit/LayoutTests/fast/hidpi/offset-path-ray-expected.html [add] https://crrev.com/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa/third_party/WebKit/LayoutTests/fast/hidpi/offset-path-ray.html [add] https://crrev.com/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa/third_party/WebKit/LayoutTests/fast/hidpi/offset-path-string-expected.html [add] https://crrev.com/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa/third_party/WebKit/LayoutTests/fast/hidpi/offset-path-string.html [modify] https://crrev.com/c1229dbd9e3cd0af88c684124ba5b7ef10a4daaa/third_party/WebKit/Source/core/style/ComputedStyle.cpp
,
Jan 11 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Nov 15 2017