Regression: Blink of highlight is seen on thumbnail after right clicking on it.
Reported by
db...@etouch.net,
Nov 15 2017
|
|||||||
Issue descriptionChrome Version: 64.0.3269.0 Revision 41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2-refs/heads/master@{#516552}(32/64 bit) OS: Windows(7,8,10), Mac(10.12.6,10.13.2), Linux(14.1 LTS) What steps will reproduce the problem? (1) Launch chrome, open NTP and right click on thumbnail. (2) Observe highlight on thumbnail. Actual: Blink of highlight is seen on thumbnail after right clicking on it(i.e. Highlight is not stays) Expected: Highlight should stays on thumbnail. This is a regression issue, broken in ‘M-64’ and below per-revision bisect result. Using the per-revision bisect providing the bisect results, Good Build: 64.0.3247.0(Revision: 510692) Bad Build: 64.0.3248.0(Revision: 510988) You are probably looking for a change made after 510840 (known good), but no later than 510841 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/22b22f21e78ef21e6b9622f5104a364c551750c7..3ebe7b184b8b60fb7fdf57fea1b4868f7676614e Suspect: https://chromium.googlesource.com/chromium/src/+/3ebe7b184b8b60fb7fdf57fea1b4868f7676614e @sfiera: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Nov 15 2017
,
Nov 17 2017
,
Nov 20 2017
I'll take this, since sfiera@ is out this week. I can reproduce on Mac Canary 64.0.3273.0, but interestingly not on a current Linux trunk build (64.0.3274.0).
,
Nov 20 2017
,
Nov 20 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ac71b9a6a09fa5b595920250b4c9a20a3d3697a commit 7ac71b9a6a09fa5b595920250b4c9a20a3d3697a Author: Marc Treib <treib@chromium.org> Date: Wed Nov 22 11:24:33 2017 Local NTP: Apply tile highlight also on :focus-within With this change, a tile will also be highlighted when right-clicking its "x" in the top right. This was the previous behavior, but was broken by making the "x" keyboard-focusable in https://crrev.com/c/725659. While we're here, also remove the "-webkit" prefix from the CSS "filter" property, since Chrome doesn't need it anymore. Bug: 785215 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5b2451b2a33bbf021f2328fbec3733bc20d0f3ab Reviewed-on: https://chromium-review.googlesource.com/779122 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#518606} [modify] https://crrev.com/7ac71b9a6a09fa5b595920250b4c9a20a3d3697a/chrome/browser/resources/local_ntp/most_visited_single.css
,
Nov 22 2017
,
Nov 23 2017
Just to update: Above issue is fixed on Windows(7,8,10), Mac(10.12.6,10.13.2) and Linux(14.1 LTS) using latest canary build #64.0.3276.0 Thank you. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by msrchandra@chromium.org
, Nov 15 2017