New issue
Advanced search Search tips

Issue 785187 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

virtual/.../elements-panel-rewrite-href.js in webkit_layout_tests failing on Mac

Project Member Reported by jdoerrie@chromium.org, Nov 15 2017

Issue description

virtual/mojo-loading/http/tests/devtools/elements/elements-panel-rewrite-href.js in webkit_layout_tests failing on Mac

Builders failed on: 
- Mac10.11 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
- WebKit Mac10.10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10
- WebKit Mac10.12: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12


I will disable the test. Assigning to einbinder@ due to being the last person to touch elements-panel-rewrite-href.js in https://crrev.com/c/767847. einbinder@, please re-route if appropriate.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1faf1af2d61bee80b990b61848d29ddc54cf5d76

commit 1faf1af2d61bee80b990b61848d29ddc54cf5d76
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Nov 15 11:47:55 2017

Disable elements-panel-rewrite-href.js on Mac

TBR=jdoerrie

Bug: 785187
Change-Id: Ie373f5d2d23dcef3cffca265588f98afab6511f5
Reviewed-on: https://chromium-review.googlesource.com/771430
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516669}
[modify] https://crrev.com/1faf1af2d61bee80b990b61848d29ddc54cf5d76/third_party/WebKit/LayoutTests/TestExpectations

Those tests I reported above are not virtual tests. They are 
http/tests/devtools/elements/elements-panel-rewrite-href.js
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3d9c69e3c7b8d5d9bdf168cb84c07f4c87adf4

commit fa3d9c69e3c7b8d5d9bdf168cb84c07f4c87adf4
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Nov 15 20:39:57 2017

Mark http/tests/devtools/elements/elements-panel-rewrite-href.js as Flake
TBR: einbinder

Bug: 785187
Change-Id: I289fe34aaf3f90f6c315ef7efdf3cdd72d0162f5
Reviewed-on: https://chromium-review.googlesource.com/772322
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516809}
[modify] https://crrev.com/fa3d9c69e3c7b8d5d9bdf168cb84c07f4c87adf4/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54e6b8639f00160e5083cda75205e378e1c577d

commit e54e6b8639f00160e5083cda75205e378e1c577d
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Nov 15 21:46:15 2017

Mark virtual/mojo-loading/http/tests/devtools/elements/elements-panel-rewrite-href.js flaky on Linux
TBR: einbinder

Bug: 785187
Change-Id: I2e036f2fcc16c6464b1ac142527a47bf6421bb18
Reviewed-on: https://chromium-review.googlesource.com/773058
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516838}
[modify] https://crrev.com/e54e6b8639f00160e5083cda75205e378e1c577d/third_party/WebKit/LayoutTests/TestExpectations

Comment 7 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium

Comment 8 by brat...@opera.com, Mar 15 2018

Same as  bug 806645 ?

Sign in to add a comment