New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 785184 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Nov 2017
Cc:
█ noyau@chromium.org
linds...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

First omnibox suggestion is crashing

Project Member Reported by gambard@chromium.org, Nov 15 2017 
What steps will reproduce the problem?
(1) Type the beginning of a url in the omnibox
(2) Make sure the first suggestions is a URL
(3) Tap on the first suggestion

What is the expected result?
The suggestion should be loaded.

What happens instead?
App crash.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5144bfbdaf6e8179e7d4aa657dd26ffd77e09044

commit 5144bfbdaf6e8179e7d4aa657dd26ffd77e09044
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Nov 15 10:07:52 2017

Fix WebState usage in PreloadController

During a rebase, a webState is used after being moved.
It leads to a crash when the user tap the first suggestion shown by the
omnibox, if it is a URL.

Bug:  785184 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8280af167d71e023597451c113466bf9c212aa54
Reviewed-on: https://chromium-review.googlesource.com/771331
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516654}
[modify] https://crrev.com/5144bfbdaf6e8179e7d4aa657dd26ffd77e09044/ios/chrome/browser/prerender/preload_controller.mm

Comment 2 by gambard@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)

Comment 3 by shbarezer@chromium.org, Nov 21 2017

Status: Verified (was: Fixed)
Verified in 64.0.3271.0, iPhone 6 iOS 10.3.3, iPhone 7 iOS11, iPad Pro iOS11.2
Looks good.

Comment 4 by sdefresne@chromium.org, Dec 4 2017 

Issue 785946 has been merged into this issue.

Comment 5 by linds...@chromium.org, Dec 4 2017

Cc: linds...@chromium.org noyau@chromium.org
@gamabrd Has a regression automated test been added for this scenario?

Comment 6 by gambard@chromium.org, Dec 4 2017 

I don't think a test has been added.

Comment 7 by linds...@chromium.org, Dec 4 2017 

For a regression severe as this it's important to add automated coverage. I'm surprised it wasn't requested during the CL review :) Can you please add a test for this?
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7e1c873fe7f49ec1d6b4f155defe9e056af79ef

commit c7e1c873fe7f49ec1d6b4f155defe9e056af79ef
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Dec 08 11:15:14 2017

Add a test for the prerendered suggestions

This CL adds a test to check that the prerendered suggestions is
displayed when tapped.

Bug:  785184 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8f656c00e946e2048483d911f03743ef2dc21081
Reviewed-on: https://chromium-review.googlesource.com/810785
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522759}
[modify] https://crrev.com/c7e1c873fe7f49ec1d6b4f155defe9e056af79ef/ios/chrome/browser/prerender/BUILD.gn
[add] https://crrev.com/c7e1c873fe7f49ec1d6b4f155defe9e056af79ef/ios/chrome/browser/prerender/prerender_egtest.mm
[modify] https://crrev.com/c7e1c873fe7f49ec1d6b4f155defe9e056af79ef/ios/chrome/test/earl_grey/BUILD.gn

Comment 9 by vbarig...@chromium.org, Dec 12 2017 

Verified in 65.0.3292.0 on iPhone 8 plus with iOS 11.2 beta 6, iPhone 7 plus with iOS 10.3.3, iPad Air 11.2 beta 6, 10.3.3 following steps mentioned in comment #0.  No crashes observed.  Looks good.

Comment 10 by linds...@chromium.org, Dec 12 2017 

Thanks, @gambard!
►

Sign in to add a comment