New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Consistent webkit_layout_tests failures on Win 7 Tests (dbg) and WebKit Mac

Project Member Reported by jdoerrie@chromium.org, Nov 15 2017

Issue description

Consistent webkit_layout_tests failures on Win 7 Tests (dbg)

The following webkit_layout_tests have been failing consistently in the last ~4 builds:

* http/tests/devtools/console/console-viewport-stick-to-bottom.js
* http/tests/inspector-protocol/network/redirect-interception-blocked.js
* http/tests/inspector-protocol/network/redirect-interception-mocked.js
* http/tests/inspector-protocol/network/redirect-interception-modified.js
* http/tests/inspector-protocol/network/redirect-interception.js
* http/tests/inspector-protocol/network/request-interception-on-both-redirect-rewrite.js
* http/tests/inspector-protocol/network/request-interception-on-response-redirect.js
* virtual/mojo-loading/http/tests/devtools/console/console-viewport-stick-to-bottom.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/redirect-interception-blocked.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/redirect-interception-mocked.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/redirect-interception-modified.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/redirect-interception.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/request-interception-on-both-redirect-rewrite.js
* virtual/mojo-loading/http/tests/inspector-protocol/network/request-interception-on-response-redirect.js


Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

I will disable them now.
 
Labels: Pri-2
Owner: allada@chromium.org
Status: Assigned (was: Available)
https://crrev.com/c/771351 disables the test, assigning this bug to allada@ due to the likely related https://crrev.com/c/754007.

allada@, please investigate and re-route if appropriate.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42338af801f70df9760502cf43936fb041ac134d

commit 42338af801f70df9760502cf43936fb041ac134d
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Nov 15 10:21:33 2017

Disable Failing Tests on Win7 Debug

TBR=jdoerrie

Bug:  785179 
Change-Id: I963fa3eecc9a7eae83893853dce2f9410beabb36
Reviewed-on: https://chromium-review.googlesource.com/771351
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516655}
[modify] https://crrev.com/42338af801f70df9760502cf43936fb041ac134d/third_party/WebKit/LayoutTests/TestExpectations

Summary: Consistent webkit_layout_tests failures on Win 7 Tests (dbg) and WebKit Mac (was: Consistent webkit_layout_tests failures on Win 7 Tests (dbg))
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cba7f02feddb80ccb04d0a74da995e22b77af56

commit 3cba7f02feddb80ccb04d0a74da995e22b77af56
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Nov 15 20:53:24 2017

Mark virtual/mojo-loading/http/tests/devtools/console/console-viewport-stick-to-bottom.js as flake

Bug:  785179 
Change-Id: I31e0514cf5f3293b2efd646854f7b9c4b5ea891a
Reviewed-on: https://chromium-review.googlesource.com/772404
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516818}
[modify] https://crrev.com/3cba7f02feddb80ccb04d0a74da995e22b77af56/third_party/WebKit/LayoutTests/TestExpectations

It looks like r516601 might have fixed the failing inspector-protocol/network/* tests, as they didn't fail for builds 64646, 64647 and 64648. r516655 from #c2 was only active starting in build 64649.

Hence I will remove the expectations for these tests and see if they continue passing.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d3b70631eed4e19f6899d8eb135ba4a9f44943

commit b5d3b70631eed4e19f6899d8eb135ba4a9f44943
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Nov 16 12:44:58 2017

Re-Enable inspector-protocol/network/* tests

TBR=allada

Bug:  785179 
Change-Id: I7a1c756322a6e89e3bba07009fe38c7c5911710b
Reviewed-on: https://chromium-review.googlesource.com/774285
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517066}
[modify] https://crrev.com/b5d3b70631eed4e19f6899d8eb135ba4a9f44943/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium

Comment 9 by allada@chromium.org, Nov 21 2017

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
console-viewport-stick-to-bottom.js is still failing

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/10935
Labels: Type-Bug
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f1e06936eb667cf8ac8b28b848996c81010c1d

commit 07f1e06936eb667cf8ac8b28b848996c81010c1d
Author: Scott Little <sclittle@chromium.org>
Date: Tue Nov 28 20:59:41 2017

Mark console-viewport-stick-to-bottom.js layout test as flaky on Mac.

TBR=allada@chromium.org

Bug:  785179 
Change-Id: I148b8511fa1c7d38fd9d9db8a5caa00d3616bcf1
Reviewed-on: https://chromium-review.googlesource.com/794513
Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519827}
[modify] https://crrev.com/07f1e06936eb667cf8ac8b28b848996c81010c1d/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment