New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 785171 link

Starred by 2 users
Status: Fixed
Owner:
schenney@chromium.org
Closed: Jan 4
Cc:
█ vamshi.k...@techmahindra.com
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

background-size cover fails to render properly. It adds 1px transparent line at side

Reported by rol...@nextendweb.com, Nov 15 2017 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Example URL:
https://jsfiddle.net/r6dkqusm/1/

Steps to reproduce the problem:
1. Go to the page: https://jsfiddle.net/r6dkqusm/1/
2. If you see a red 1px line on any side, it fails to render properly

What is the expected behavior?
Backgorund-size: cover; should fill up the entire div with the given backgorund image.

What went wrong?
It does not fill up the entire div as it leaves out a 1px line.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? N/A 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
Capture.PNG
292 KB View Download

Comment 1 by manoranj...@chromium.org, Nov 15 2017

Labels: Needs-Triage-M62

Comment 2 by rol...@nextendweb.com, Nov 15 2017 

OSX Chrome 61.0.3163.100 Fails too.

Comment 3 by rol...@nextendweb.com, Nov 16 2017 

Here is the triangle:
Chrome 60 Fails, 1 red pixel line at right only
Chrome 58 Fails, 1 red pixel line at right only
Chrome 50 Fails, 1 red pixel line at right only
Chrome 49.0.2623.112 Fails, 1 red pixel line at right and bottom
Chrome 48.0.2564.109 works fine

Comment 4 by vamshi.k...@techmahindra.com, Nov 16 2017

Cc: vamshi.k...@techmahindra.com
Labels: -Type-Compat Triaged-ET M-64 OS-Linux OS-Mac Type-Bug
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on the reported chrome version stable 62.0.3202.94 and the latest canary 64.0.3270.0 using Windows10, Ubuntu14.04 and Mac 10.12.6. As the issue is seen from M(50) 50.0.2661.26 hence considering it as non-regression and marking it as untriaged.

Comment 5 by dtapu...@chromium.org, Nov 17 2017

Components: Blink>Paint

Comment 6 by schenney@chromium.org, Nov 17 2017

Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)
The is a subpixel rounding issue. It's on my agenda to fix this, really.

Comment 7 by rol...@nextendweb.com, Jan 4 2018 

It would be great to see a fix for this issue. I saw it all the time while testing on different browser widths.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae49f5caf2943049acab4abe802e82c8dc001184

commit ae49f5caf2943049acab4abe802e82c8dc001184
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Jun 29 16:22:40 2018

[PE] Improve background image painting

This patch corrects most of the known issues we have with sprite use
in background images under zoom, cracks at the border of background
images, failing to fill the positioning area with round, cover and
space, etc. There may still be cases we fail at but they do not appear
in bug reports or they are significantly harder to fix (meaning
requiring changes in Skia or elsewhere).

The primary change is to track snapped and unsnapped values throughout
the background rendering pipleline, and use the appropriate values
for every calculation. In general, this means using unsnapped values
when trying to compute something related to source pixels, and snapped
values when trying to describe the region for painting or calculations
intended to interact with the destination region.

There is scope for simplifying the code but they can wait until this
has landed and stuck. In particular, we add and then subtract offsets
when determinine source rects. And we do some odd adjustments for
certain scrolling cases that seem like they could be removed.

New tests cover various sprite sampling under zoom conditions.
Several ref tests had to be converted to image tests because repeated
images are now sub-pixel sized and cannot easily be matched with a
reference result.

R=fmalita@chromium.org,fs@opera.com

Bug:  823339 , 825239 ,805495, 785171 , 710342 , 659825 , 449600 , 594481 , 589449 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I32689f285d621afb7ec929eb193d7683dd15ff01
Reviewed-on: https://chromium-review.googlesource.com/1112563
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#571505}
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-color-gradient-alignment-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-percent-position-sprite-zoomed-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-percent-position-sprite-zoomed-expected.txt
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-percent-position-sprite-zoomed.html
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-auto1-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-auto1-expected.txt
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-border-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-border-expected.txt
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-content-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-content-expected.txt
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-padding-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/background-repeat-round-padding-expected.txt
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/resources/large-sprite-map.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/zoomed-background-position-accuracy-2-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/zoomed-background-position-accuracy-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/zoomed-background-position-accuracy-expected.txt
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/background/zoomed-background-position-accuracy.html
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-auto1-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-auto1-expected.txt
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-border-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-border-expected.txt
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-padding-expected.html
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/css3/masking/mask-repeat-round-padding-expected.txt
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/background-cover-rounding-expected.html
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/fast/backgrounds/background-tiling-sub-pixel-expected.html
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize01-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize02-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize05-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize08-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize09-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize10-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize11-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize12-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize13-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize14-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize17-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize18-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize19-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize20-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize21-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/backgroundSize22-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/backgrounds/size/scaled-sprited-background-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/fast/table/backgr_simple-table-collapsed-border.html
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/gradients/simple-gradients-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/backgr_simple-table-row-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/tables/mozilla_expected_failures/other/test4-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box.htm
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/images/color-profile-background-image-repeat-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/images/color-profile-background-image-space-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/images/color-profile-mask-image-svg-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/images/cross-fade-tiled-expected.png
[delete] https://crrev.com/8117ad42726252bd38e4f4908f9e15daa0b4c831/third_party/WebKit/LayoutTests/images/sprite-no-bleed-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/paint/masks/fieldset-mask-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-tiling-sub-pixel-expected.png
[add] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/background-tiling-sub-pixel-expected.txt
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/size/backgroundSize16-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/backgrounds/size/contain-and-cover-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/gradients/simple-gradients-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/inline/inline-box-background-repeat-y-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82c8dc001184/third_party/WebKit/LayoutTests/platform/linux/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ae49f5caf2943049acab4abe802e82

Comment 9 by schenney@chromium.org, Jun 30 2018 

Better now, in that it works at 100% and higher zoom, but fails at 80% for some reason.

Comment 10 by diachede...@gmail.com, Nov 14 

Article demonstrating the bug with a couple of workarounds: https://medium.com/@ryanjw/buggy-edges-in-chrome-when-using-background-size-cover-dd6eb44541fc

Comment 11 by rol...@nextendweb.com, Nov 14 

https://jsfiddle.net/r6dkqusm/1/

I can confirm that the example fails at 80% and 90% zoom.

Comment 12 by schenney@chromium.org, Dec 21

Status: Started (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcec81e12c80bd5a091645c554362f6c4d43febd

commit dcec81e12c80bd5a091645c554362f6c4d43febd
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Jan 04 16:11:11 2019

Make background-size: cover and contain really cover

With background-repeat: no-repeat and background-size: cover, the
computations for dest rect for the no-repeat case use the tile size
to set the dest rect. This prevents tiled drawing from painting more
than one tile. But the background-size computations for cover and
contain use an unsnapped position area to set the tile size, which
produces an unsnapped tile size. This unsnapped tile size, when set as
the dest rect for painting, results in a tile that doesn't fill the
background as one would expect for cover or contain.

This patch switches to always computing the cover and contain tile
sizes using a snapped position area to give a snapped dest rect.

R: fs@opera.com, fmalita@chromium.org
Bug:  785171 
Change-Id: I38343ac09d689e9d1360e7043b2ef49adeadb983
Reviewed-on: https://chromium-review.googlesource.com/c/1394014
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619962}
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/renderer/core/paint/background_image_geometry.cc
[add] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-cover-zoomed-1.html
[add] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-cover-zoomed-1-ref.html
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/virtual/exotic-color-space/images/color-profile-background-image-cover-expected.png
[modify] https://crrev.com/dcec81e12c80bd5a091645c554362f6c4d43febd/third_party/blink/web_tests/virtual/gpu-rasterization/images/color-profile-background-image-cover-expected.png

Comment 14 by schenney@chromium.org, Jan 4

Status: Fixed (was: Started)
I don't think we will merge this back. Expect it fixed as M-73 rolls through the release process (starting with tomorrow's Canary).
►

Sign in to add a comment