Issue metadata
Sign in to add a comment
|
Regression: Focus doesn't shift to Guest mode/Manage people button on hovering using mouse |
||||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3269.0 OS: Ubuntu 14.04 What steps will reproduce the problem? (1) Launch chrome and click on avatar button [Observe default focus on Sign in to chrome button] (2) Hover mouse on Manage People/Guest mode buttons so that focus should move away from sign in to chrome and should be seen on either of Manage People/Guest mode Expected: On hovering Manage People/Guest mode and clicking enter should open Manage People/Guest mode windows. Actual: Instead Sign in to chrome overlay is seen. This is a regression issue broken in M64. Good Build: 64.0.3264.0 Bad Build: 64.0.3266.0 NOTE: Issue is not seen on Mac.
,
Nov 15 2017
Correction in manual bisect info: ================================== Good Build: 64.0.3264.0 Bad Build: 64.0.3265.0 You are probably looking for a change made after 515442 (known good), but no later than 515443 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/2e7619405ff3e99d6e24758165d89e307310e1c2..7d840bcd63eaa0b76005bcd4b16a4f6fed0619a1 Reviewed-on: https://chromium-review.googlesource.com/730031 Suspecting same from above changelog. @patricialor: Please confirm the bug and help in re-assigning if it is not related to your change. Thanks!
,
Nov 16 2017
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c commit 2dd7f6c07aa8da74798ccdee953cc33e8d484b2c Author: Patti <patricialor@chromium.org> Date: Thu Nov 16 05:21:19 2017 Profile Chooser/Views: Only one HoverButton can be highlighted at a time. When mouse hovering and tabbing through the buttons in the ProfileChooserView at the same time, it is possible to get two different buttons to be highlighted. Prevent this by requesting focus on hover, then highlighting on focus only. This prevents confusion about which item actually has keyboard focus. This has the desired side effect of making the fade-in animation duration instant as well ( crbug.com/784684 ). Bug: 785164 , 785262 , 784684 Change-Id: Id379f2c373307f2c49dbce58cf40d3d61f9f324e Reviewed-on: https://chromium-review.googlesource.com/773319 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#516996} [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.cc [modify] https://crrev.com/2dd7f6c07aa8da74798ccdee953cc33e8d484b2c/chrome/browser/ui/views/hover_button.h |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Nov 15 2017