New issue
Advanced search Search tips

Issue 785150 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in getIConst

Project Member Reported by ClusterFuzz, Nov 15 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6319256064229376

Fuzzer: libFuzzer_swiftshader_vertex_routine_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x62500007c900
Crash State:
  getIConst
  TIntermConstantUnion::fold
  TIntermediate::addBinaryMath
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=512583:512623

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319256064229376

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 15 2017

Labels: M-64
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 15 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 15 2017

Labels: Pri-1
Components: Internals>GPU>SwiftShader
Owner: cwallez@chromium.org
Status: Assigned (was: Untriaged)
cwallez: Would you mind taking a look at this? Also, could you let us know if earlier versions are affected since it seems like we started hitting this after a fuzzer change? We'll want to update the impact/milestone/releaseblock labels if so.
Cc: cwallez@chromium.org
Owner: capn@chromium.org
Assigning to capn@. The issue certainly predates the fuzzer.

Comment 6 by capn@chromium.org, Nov 27 2017

Labels: -Pri-1 -ReleaseBlock-Stable ReleaseBlock-NA Pri-2
This is an issue in the constant folding of the GLSL compiler, which is old code. It only affects the GPU process, so its security implications are minimal. We'll look into this and related bugs when revamping the compiler.
Project Member

Comment 7 by ClusterFuzz, Dec 5 2017

ClusterFuzz has detected this issue as fixed in range 521502:521564.

Detailed report: https://clusterfuzz.com/testcase?key=6319256064229376

Fuzzer: libFuzzer_swiftshader_vertex_routine_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x62500007c900
Crash State:
  getIConst
  TIntermConstantUnion::fold
  TIntermediate::addBinaryMath
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=512583:512623
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=521502:521564

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6319256064229376

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 5 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6319256064229376 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 5 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by sheriffbot@chromium.org, Mar 13 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable

Sign in to add a comment