Rich Text editor : format is lost on selecting bold
Reported by
srinathr...@gmail.com,
Nov 15 2017
|
||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36 Steps to reproduce the problem: 1. Launch rtetest.html in chrome 62 or latest. 2. Place the cursor in the editable area. 3. Click on the Bold button. 4. Enter text. What is the expected behavior? The entered text is not in bold. The same code and use case was working fine in chrome 61 but not working in chrome 62. Please let us know what we need to change in the js code to make it work in chrome 62. What went wrong? We are simply calling the execCommand on clicking on the bold button. If we select text and click on bold and enter text then there is no issue. But when click on the bold button and enter text, the text is not in bold. Did this work before? Yes Chrome 61 Does this work in other browsers? Yes Chrome version: 62.0.3202.94 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Nov 16 2017
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #62.0.3202.94 and latest canary #64.0.3269.3. Issue is not seen on OS-Mac. Bisect Information: ===================== Good build: 62.0.3175.0 Revision(491592) Bad Build : 62.0.3176.0 Revision(491883) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/447975f2f54a2fd264da3762b8f5470ad2d59da7..e51004f83bece58455811a9195a21001c937019a Unable to find any possible suspect from the above change log url. Hence, marking it as untriaged and requesting any dev to please help us in assigning it to the right owner. Note: Adding label ReleaseBlock-Stable, as it is regressed in M62. In case we plan for any stable refresh please feel free to update the milestone and blocker label if someone feels otherwise. Thanks...!!
,
Nov 16 2017
Please let us know, Is there anything need to handle when we are using execCommand. All our customer facing the issues in chrome 62 and all the work is getting blocked.
,
Nov 16 2017
Punting this to M63.
,
Nov 16 2017
M63 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 16 2017
eae@, could you ptal and reassign to appropriate dev if needed?
,
Nov 17 2017
yosin@ can you please take a look at this regression.
,
Nov 17 2017
Bisects to: https://chromium.googlesource.com/chromium/src/+/9063cb91499ef3cf13e085ae4ad27ae52e09019a Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded() This patch gets rid of redundant call of |SetIsDirectional()| in |SelectionController::SetNonDirectionalSelectionIfNeeded()|, because - We want to set non-directional selection as function name suggested - In |FrameSelection::SetSelection()|, we always set directional selection if |ShouldConsiderSelectionAsDirectional()| is true. Bug: 740804 Change-Id: Ia474742aee16d13e124c41f4d7830614c35bd2f2 Reviewed-on: https://chromium-review.googlesource.com/595427 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491618}
,
Nov 17 2017
I suspect the bug does not occur on macOS because ShouldConsiderSelectionAsDirectional() returns false for macOS and true for all other platforms.
,
Nov 20 2017
,
Nov 20 2017
xiaochengh@ Please re-assign this issue if you are not the right owner.
,
Nov 20 2017
Confirm that it doesn't occur on macOS. Tested on Mac Canary 64.0.3273.0. Is there a step missing in the repro steps? After "3. Click on the Bold button", the editable iframe loses focus. The script calls focus() on the iframe, which however doesn't seem to work. An addition click in the iframe is needed to set the focus back, so that "4. Enter text." is possible. This missing step also makes the bisection result reasonable, because SelectionController is invoked only when mouse/touch operations are involved.
,
Nov 20 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/217d5aa0eba9d6e74f54712b1c1c5197442d5738 commit 217d5aa0eba9d6e74f54712b1c1c5197442d5738 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Nov 21 03:30:55 2017 Revert "Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded()" This is a manual revert of commit 9063cb91499ef3cf13e085ae4ad27ae52e09019a. Reason of revert: causing crbug.com/785147 . The |SetIsDirectional()| call removed in the reverted CL turns out to be not redundant: it affects the |IsDirectional()| value of |selection_in_flat_tree|, which is taken into the decision of whether to abort the current operation or not. Bug: 785147 , 740804 Change-Id: I7f92ae1fe5223557346360a4509a3e448b0165fc Reviewed-on: https://chromium-review.googlesource.com/779967 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#518086} [add] https://crrev.com/217d5aa0eba9d6e74f54712b1c1c5197442d5738/third_party/WebKit/LayoutTests/editing/selection/mouse/click_back_does_not_clear_editing_style.html [modify] https://crrev.com/217d5aa0eba9d6e74f54712b1c1c5197442d5738/third_party/WebKit/Source/core/editing/SelectionController.cpp
,
Nov 22 2017
,
Nov 22 2017
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 22 2017
Merge approved upon verification of the fix in Canary and the branch 3239 after merging it.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3e1ef2c9caecf8fec563eaa34b0e58282995282 commit b3e1ef2c9caecf8fec563eaa34b0e58282995282 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Nov 22 20:42:34 2017 Revert "Get rid of redundant call of SetIsDirectional() in SelectionController::SetNonDirectionalSelectionIfNeeded()" This is a manual revert of commit 9063cb91499ef3cf13e085ae4ad27ae52e09019a. Reason of revert: causing crbug.com/785147 . The |SetIsDirectional()| call removed in the reverted CL turns out to be not redundant: it affects the |IsDirectional()| value of |selection_in_flat_tree|, which is taken into the decision of whether to abort the current operation or not. Bug: 785147 , 740804 Change-Id: I7f92ae1fe5223557346360a4509a3e448b0165fc Reviewed-on: https://chromium-review.googlesource.com/779967 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#518086}(cherry picked from commit 217d5aa0eba9d6e74f54712b1c1c5197442d5738) Reviewed-on: https://chromium-review.googlesource.com/786352 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#562} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [add] https://crrev.com/b3e1ef2c9caecf8fec563eaa34b0e58282995282/third_party/WebKit/LayoutTests/editing/selection/mouse/click_back_does_not_clear_editing_style.html [modify] https://crrev.com/b3e1ef2c9caecf8fec563eaa34b0e58282995282/third_party/WebKit/Source/core/editing/SelectionController.cpp
,
Nov 22 2017
,
Nov 28 2017
Rechecked this issue on Windows 10 and Ubuntu 140.4 using chrome version 63.0.3239.68 and fix is working as intended. Clicking Bold button and typing text in the text area displays letters in Bold. Adding TE-verified labels for M63. Thanks.!
,
Nov 29 2017
Android: Works as per expected behavior and Issue verified on 63.0.3239.68
,
Nov 30 2017
Android: Works as per expected behavior and Issue verified on 64.0.3281.0 |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by manoranj...@chromium.org
, Nov 15 2017