Regression: Unable to check/uncheck the View Options checkboxes on chrome://tracing page.
Reported by
dchau...@etouch.net,
Nov 15 2017
|
||||
Issue descriptionChrome Version: 64.0.3268.0 2af1c4f37d23500cc3e71fe058ba4efd55ed35c6-refs/heads/master@{#516147}(64-bit) OS: Win(7,8,10),Mac(10.12.6,10.13.2),Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch Chrome, go to chrome://tracing page and click on 'View Options' at header. 2. Now click on "Flow events/Highlight VSync" checkbox and observe. Unnecessary View Options drop-down list gets closed and unable to check/uncheck the checkboxes. On clicking checkboxes, drop-down list should not get closed and checkboxes should be clickable. This is a regression issue, broken in M-64 series, will soon update other info.
,
Nov 15 2017
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Nov 21 2017
Still we are able to reproduce the issue on Windows 7, mac 10.12.6 & ubuntu 14.04 using chrome latest Canary-64.0.3273.3 as per C#0. benjhayden@, Could you please check and update the bug accordingly as it is marked as stable blocker. Thank you.
,
Nov 22 2017
,
Nov 22 2017
Culprit is: https://chromium.googlesource.com/catapult.git/+/7d0ab7044d5ea2c71ba38e04a3161833ff93acd8 It still reverts cleanly. People who need to look at flow events in a ToT developer build can just do this under the third_party/catapult directory: git revert 7d0ab7044d5ea2c71ba38e04a3161833ff93acd8
,
Nov 28 2017
benjhayden@, Friendly ping to get an update on this issue as it is marked as stable blocker. Thanks..!
,
Nov 29 2017
M-64 branch point is only one day away. I created a revert: https://chromium-review.googlesource.com/c/catapult/+/797390 Can't land it because I do not have review privileges in the catapult repository. Could someone on the team just hit the button?
,
Nov 29 2017
Really sorry about that, slipped off my radar. Just lgtm'd it.
,
Nov 29 2017
,
Nov 29 2017
Cool. Not clear whether DEPS will be rolled prior to branch. To be safe, let's keep this issue open until we've confirmed the revert was picked up in the M-64 DEPS.
,
Nov 29 2017
Ah. Revert stopped just in time!
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/81d3bd9213f44aa05c1323e5b1cf648cea0d1950 commit 81d3bd9213f44aa05c1323e5b1cf648cea0d1950 Author: Ben Hayden <benjhayden@chromium.org> Date: Wed Nov 29 18:15:56 2017 Fix "View Options" dropdown in trace viewer. The tr-ui-b-dropdown dom-module encapsulates a modal dialog that drops down from a button. When the user clicks outside of the modal dialog, it closes. When the user clicks inside of the modal dialog, it should not close. Due to the way that modal dialogs are implemented, clicking inside of the dialog produces the same type of event as clicking outside of it, so it is common for modules such as tr-ui-b-dropdown to compare the coordinates of the click event to the bounding rect of the dialog in order to determine whether the click was inside or outside of the dialog. Polymer defines 'tap' events as a generalization of click events that support touch screens as well as mouse pointers. However, there is a crucial difference between click events and polymer tap events: click event coordinates are given by event.clientX and event.clientY, whereas tap event coordinates are given by event.detail.x and event.detail.y. When a recent change upgraded the click event handler to a tap event handler, it failed to update the clientX/clientY references to point to the Polymer tap event's detail.x/y. This CL fixes the click-event-style clientX/clientY references to correctly reference the tap-event-style detail.x/y. The new test fails without the fix. Bug: chromium:785138 Change-Id: I006652066a2d56a6219757f1815bfe9bad7bb54e Reviewed-on: https://chromium-review.googlesource.com/795110 Reviewed-by: Ethan Kuefner <eakuefner@chromium.org> Commit-Queue: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/81d3bd9213f44aa05c1323e5b1cf648cea0d1950/tracing/tracing/ui/base/dropdown_test.html [modify] https://crrev.com/81d3bd9213f44aa05c1323e5b1cf648cea0d1950/tracing/tracing/ui/base/dropdown.html
,
Nov 29 2017
This should be fixed. Do I need to request merge? |
||||
►
Sign in to add a comment |
||||
Comment 1 by dchau...@etouch.net
, Nov 15 2017Owner: benjhayden@chromium.org
Status: Assigned (was: Unconfirmed)
629 KB
629 KB View Download
233 KB
233 KB View Download