Issue metadata
Sign in to add a comment
|
BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing/0 is failing on chromium.linux/Linux Tests |
||||||||||||||||||||
Issue descriptionsite_per_process_browser_tests failing on chromium.linux/Linux Tests Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/64549 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Tests%2F64549%2F%2B%2Frecipes%2Fsteps%2Frenderer_side_navigation_browser_tests%2F0%2Flogs%2FBrowserCloseManagerBrowserTest__x2f_BrowserCloseManagerBrowserTest.AddBeforeUnloadDuringClosing__x2f_0%2F0 This failure shows up in browser_tests, site_per_process_browser_tests, and renderer_side_navigation_browser_tests in various forms in builds 64549..64552 It's not immediately obvious to me which CL is the culprit here, but I am speculatively guessing that it's the mojo change in https://chromium-review.googlesource.com/768097 . I'm going to try to revert that now; if that doesn't work, I'll leave this for the next sheriff, and we may need to disable the test if we can't bisect it and figure out what the cause is.
,
Nov 15 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3146d14ff14dd6da0acf47e6aab87a288acab77e commit 3146d14ff14dd6da0acf47e6aab87a288acab77e Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Nov 15 22:27:40 2017 Convert IPC SuddenTerminationChanged to mojo. Change mojom::RendererHost to be associated This is a reland of crrev.com/c/785121 with mojo interface updated to be assoicated and preserve message ordering. Bug: 775809 Bug: 785121 Change-Id: Ib5fc3bb32cfe343d8e9a34aaa32bba2b13925ef7 Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/770676 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#516862} [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/common/render_process_messages.h [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/common/renderer_host.mojom [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/render_thread_impl.cc [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/render_thread_impl.h [modify] https://crrev.com/3146d14ff14dd6da0acf47e6aab87a288acab77e/content/renderer/renderer_blink_platform_impl.cc
,
Nov 15 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by joelhockey@chromium.org
, Nov 15 2017