renamed CheckChangedConfigs to something LUCI-specific |
||||
Issue descriptionwe have a canned presubmit check called CheckChangedConfigs that validates that any LUCI configs that are changed in a patch are correct. For a project like Chromium, where we have both a lot of presubmit checks, and a lot of different types of config files, that name is not descriptive enough, so we should change this to something like CheckChangedLUCIConfigs().
,
Nov 15 2017
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/00fc72856bb0a8f5889409c992b8123e79a852a6 commit 00fc72856bb0a8f5889409c992b8123e79a852a6 Author: Mun Yong Jang <myjang@google.com> Date: Wed Nov 22 19:37:21 2017 [presubmit] Rename to CheckChangedLUCIConfigs Bug: 785114 Change-Id: I53c3b4e54f39f4bacf8fb0bda1de4e4b0e1b280b Reviewed-on: https://chromium-review.googlesource.com/771592 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Mun Yong Jang <myjang@google.com> [modify] https://crrev.com/00fc72856bb0a8f5889409c992b8123e79a852a6/presubmit_canned_checks.py [modify] https://crrev.com/00fc72856bb0a8f5889409c992b8123e79a852a6/tests/presubmit_unittest.py
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b97108ed731e92d02f753da35382839aed39fa57 commit b97108ed731e92d02f753da35382839aed39fa57 Author: Mun Yong Jang <myjang@google.com> Date: Mon Nov 27 21:17:10 2017 [presubmit] Rename to CheckChangedLUCIConfigs No-Try: true No-Presubmit: true Bug: 785114 Change-Id: I10f3c093a0f45dce27e056aa4eef9149e225328f Reviewed-on: https://chromium-review.googlesource.com/771970 Commit-Queue: Mun Yong Jang <myjang@google.com> Reviewed-by: Mun Yong Jang <myjang@google.com> [modify] https://crrev.com/b97108ed731e92d02f753da35382839aed39fa57/PRESUBMIT.py
,
Nov 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/b6081e5adb7b3ee0b9461cbe8ddd460f84366884 commit b6081e5adb7b3ee0b9461cbe8ddd460f84366884 Author: Mun Yong Jang <myjang@google.com> Date: Wed Nov 29 17:17:38 2017
,
Nov 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/6b40bfbfb081715824948825ff98b71ef77eded4 commit 6b40bfbfb081715824948825ff98b71ef77eded4 Author: Mun Yong Jang <myjang@google.com> Date: Wed Nov 29 17:17:59 2017
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/17995a9f128290b66e16f2fdfba96b4369425f8c commit 17995a9f128290b66e16f2fdfba96b4369425f8c Author: Mun Yong Jang <myjang@google.com> Date: Sat Dec 02 00:07:01 2017 [depot_tools] Remove deprecated config check in canned checks Bug: 785114 Change-Id: Ic98995d670b22ba17ef6139ed086cb1b31c7d39c Reviewed-on: https://chromium-review.googlesource.com/804736 Commit-Queue: Mun Yong Jang <myjang@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/17995a9f128290b66e16f2fdfba96b4369425f8c/presubmit_canned_checks.py
,
Dec 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/17995a9f128290b66e16f2fdfba96b4369425f8c commit 17995a9f128290b66e16f2fdfba96b4369425f8c Author: Mun Yong Jang <myjang@google.com> Date: Sat Dec 02 00:07:01 2017 [depot_tools] Remove deprecated config check in canned checks Bug: 785114 Change-Id: Ic98995d670b22ba17ef6139ed086cb1b31c7d39c Reviewed-on: https://chromium-review.googlesource.com/804736 Commit-Queue: Mun Yong Jang <myjang@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/17995a9f128290b66e16f2fdfba96b4369425f8c/presubmit_canned_checks.py
,
Dec 2 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by myjang@google.com
, Nov 15 2017Status: Assigned (was: Untriaged)