New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----
Team-Accessibility

Blocking:
issue 784583



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Project Member Reported by dpranke@chromium.org, Nov 15 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty MSAN

Builders failed on: 
- WebKit Linux Trusty MSAN: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/4331

I bisected these builds locally and was able to reproduce the failure, and verified that reverting https://chromium-review.googlesource.com/767427 fixed the issue :(.


 
Cc: dmazz...@chromium.org
Components: UI>Accessibility Internals>Accessibility
Labels: -Sheriff-Chromium
Status: Untriaged (was: Available)

Comment 2 by kbr@chromium.org, Nov 15 2017

Blocking: 784583

Comment 3 by jdap...@gmail.com, Nov 15 2017

I could not find any reason why libGL initialization is different with or without this patch, but unfortunately I cannot reproduce the msan error either. Is there any way to get the msan stacktrace with more detail?

Also, is there any documentation on how to reproduce the layout tests with msan enabled locally? It is failing for me to run because it already hits  errors in g_get_language_names...
I'm unable to repro locally because I upgraded my Linux box and MSAN only supports Trusty.

It looks like the msan trybot doesn't run by default?

Let's try uploading again and running the msan trybot.


Comment 5 by jose.dap...@lge.com, Nov 17 2017

https://chromium-review.googlesource.com/c/chromium/src/+/774888 is going to fix this apparently. I tried adding manually the msan trybots and actually found a problem in the objects initialization that was causing the msan error. So the updated version should not crash msan anymore (it did pass already after the fix).
correct, msan is not part of the default trybot set, but there is an optional bot that you should be able to test this on.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59b5d9892707371b36827670cb5eeb66fa932fc2

commit 59b5d9892707371b36827670cb5eeb66fa932fc2
Author: Jose Dapena Paz <jose.dapena@lge.com>
Date: Fri Nov 17 21:18:26 2017

Reland "A11y: prepare AXPlatformNodeAuraLinux to implement multiple Atk interfaces."

Original CL: https:/crrev.com/c/767427/

> As a first step towards moving all the ATK object implementation to
> ui/accessibility, we will make AXPlatformNodeAuraLinux implement as much
> as possible of the features implemented only in
> BrowserAccessibilityAuraLinux ATK object.
>
> This patch prepares AtkPlatformNodeAuraLinux to load different Atk
> interfaces.

Changes:
- Change initalization of AuraLinuxApplication so AXNodeData is initialized
  before AXPlatformNode accesses to it avoiding MSAN crash.

Bug: 784583, 785106 
Change-Id: I59804d1e859dc95fae3af06747aaa21043aed05e
Reviewed-on: https://chromium-review.googlesource.com/774888
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517557}
[modify] https://crrev.com/59b5d9892707371b36827670cb5eeb66fa932fc2/ui/accessibility/platform/ax_platform_node_auralinux.cc
[modify] https://crrev.com/59b5d9892707371b36827670cb5eeb66fa932fc2/ui/accessibility/platform/ax_platform_node_auralinux.h
[modify] https://crrev.com/59b5d9892707371b36827670cb5eeb66fa932fc2/ui/views/accessibility/native_view_accessibility_auralinux.cc
[modify] https://crrev.com/59b5d9892707371b36827670cb5eeb66fa932fc2/ui/views/accessibility/native_view_accessibility_base.cc

Comment 8 by jose.dap...@lge.com, Nov 21 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment