New issue
Advanced search Search tips

Issue 785080 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

content_browsertests failing on chromium.mac/Mac10.10 Tests in PointerLockBrowserTest.PointerLockEventRouting

Project Member Reported by dpranke@chromium.org, Nov 15 2017

Issue description

Cc: -kenrb@chromium.org lfg@chromium.org
Owner: kenrb@chromium.org
Status: Assigned (was: Available)
Ken, it looks like your reland in https://chromium-review.googlesource.com/c/chromium/src/+/769489/1..5 fixed the flakiness in PointerLockWheelEventRouting, whereas this is in PointerLockEventRouting.  It probably needs a similar fix?

Description: Show this description
Labels: -Sheriff-Chromium

Comment 4 by kenrb@chromium.org, Nov 15 2017

#1: Thanks, yes, this was an error on my part. I had indeed intended to add that guard to both tests (which are both racy), but missed one when I had moved my patch from my Mac machine to my Linux machine where I have the original CL.

New CL now uploaded, which covers both the tests in that file that need browser input event routing.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9

commit 8a319fbc7039bf38fe46bf7c5f78cca4e82206b9
Author: Ken Buchanan <kenrb@chromium.org>
Date: Wed Nov 15 18:37:12 2017

Reland: Enable render throttling for OOPIFs

Originally landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/719601

The change caused a racy test to flake on Mac and was reverted. This
patch restores the original CL and fixes the cause of the flakiness in
the problematic test.

Was earlier relanded with a fix to only one of the two tests that had
race conditions.

TBR=dcheng@chromium.org

Bug:  761478 ,  784236 ,  785080 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I947a70b256b0783b2c687c1213c6e00fe06550a8
Reviewed-on: https://chromium-review.googlesource.com/771773
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516758}
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/frame_messages.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/view_messages.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.h
[add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html
[add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClient.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebRemoteFrameClient.h

Comment 6 by kenrb@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment