New issue
Advanced search Search tips

Issue 785068 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 751321



Sign in to add a comment

memlog: Respect incognito mode

Project Member Reported by ajwong@chromium.org, Nov 15 2017

Issue description

Do not profile incognito renderers
Do not upload if there is an incognito session.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd

commit 3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd
Author: Albert J. Wong <ajwong@chromium.org>
Date: Fri Nov 17 02:59:48 2017

memlog: respect Incognito mode and Metrics collection settings.

Do not upload memory traces if there is an active incognito session
or if the user has opted out of metrics collections.

Bug:  785068 
Change-Id: If5f00792a6d1306d77c36cbd88066d39c7dbe146
Reviewed-on: https://chromium-review.googlesource.com/775735
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517263}
[modify] https://crrev.com/3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd/chrome/browser/profiling_host/background_profiling_triggers.cc
[modify] https://crrev.com/3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd/chrome/browser/profiling_host/background_profiling_triggers.h
[modify] https://crrev.com/3a1f9f3247a69dc6b304c6d41e6770fc7ff139bd/chrome/browser/profiling_host/background_profiling_triggers_unittest.cc

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25e12fffb6293835ddbea6855b76e54ad1f36f24

commit 25e12fffb6293835ddbea6855b76e54ad1f36f24
Author: erikchen <erikchen@chromium.org>
Date: Thu Dec 13 19:22:10 2018

Correctly respect incognito mode for memlog.

A previous iteration of this code checked for the existence of an incognito
profile. That was incorrect, as it's possible for an incognito profile to exist
but not be used. This code now checks that there's a window associated with an
incognito profile.

Bug:  785068 
Change-Id: I4e1550127bf2031fc6ffea1b3c59a1ec8b61a06b
Reviewed-on: https://chromium-review.googlesource.com/c/1374790
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616390}
[modify] https://crrev.com/25e12fffb6293835ddbea6855b76e54ad1f36f24/chrome/browser/profiling_host/background_profiling_triggers.cc

Sign in to add a comment