New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785059 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Log changes of effective connection type on chrome://interventions-internals.

Project Member Reported by thanhdle@chromium.org, Nov 14 2017

Issue description

Right now the page only show the current effective connection type (ECT), but does not keep the information of the transition of ECT, which might be helpful when debugging previews behaviors that based on ECT value.
 
Cc: bengr@chromium.org ryansturm@chromium.org
Cc: tbansal@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5e31e42689b1b330bc3f3c09899d9d6091ccdc

commit 6a5e31e42689b1b330bc3f3c09899d9d6091ccdc
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Nov 15 07:44:30 2017

Log ECT changes on chrome://interventions-internals.

Screenshot: https://drive.google.com/a/chromium.org/file/d/1wOa_cxHKz9URF2ZAv2-oReCpFoh34uU3

Bug:  785059 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1ddb7f2277685f64c73ed8bc8a1f2461c4f2b476
Reviewed-on: https://chromium-review.googlesource.com/770094
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516630}
[modify] https://crrev.com/6a5e31e42689b1b330bc3f3c09899d9d6091ccdc/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/6a5e31e42689b1b330bc3f3c09899d9d6091ccdc/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/6a5e31e42689b1b330bc3f3c09899d9d6091ccdc/chrome/browser/resources/interventions_internals/index.js

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4f88fd12caefe882765fdca4201d5c92125dae

commit 2e4f88fd12caefe882765fdca4201d5c92125dae
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Nov 21 23:35:47 2017

Add log message event for ECT changed in chrome://interventions-internals.

Whenever ECT changes, the a "ECT changed" event is logged on the
"Interventions Logs" table in the "Logs" tab.

Reversed the order of the ECT change logs on Network Quality so that
newer events will be appended to the top of the table.

Screenshot: https://drive.google.com/a/chromium.org/file/d/1lnhBZ3u2gOM0GlurRNgJgeg2O13uc07O
Screenshot: https://drive.google.com/a/chromium.org/file/d/1c6ekJzCQb7_RKbTWcdtZ4mfPhoUT9AyI

Bug:  785059 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9372e6c70c6b9f5d775a033bed9089f072078848
Reviewed-on: https://chromium-review.googlesource.com/783450
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518448}
[modify] https://crrev.com/2e4f88fd12caefe882765fdca4201d5c92125dae/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/2e4f88fd12caefe882765fdca4201d5c92125dae/chrome/test/data/webui/interventions_internals_browsertest.js

Status: Fixed (was: Started)

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment