Hitting back after voice search shows results for only a portion of the beginning of a multi word search |
||||||
Issue descriptionChrome Version: 64.0.3267.2 VRCore: 1.10.172754103 OS: Android N Platform: Pixel *This does not repro using voice search in 2D Chrome. What steps will reproduce the problem? (1) Go to wikipedia.org and enter Chrome VR (2) With controller, press Voice search icon (3) Speak more than one word. Eg. "Pablo Picasso" (4) Once search results are displayed, hit the back button in the url bar. What is the expected result? the wikipedia.org page is displayed. What happens instead? Google search results for just the word "Pablo" are displayed. *If you search for 1 2 3 4, sometimes hitting back shows "1", other times it shows "1 2 3". But it looks like it only breaks a search in two. E.g. hitting back multiple times on a 3+ word search does not iterate through each word, it just breaks it into 2 sections.
,
Nov 15 2017
,
Nov 17 2017
,
Nov 20 2017
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7 commit a9dc6e71746f2bcedca0757bc1e0ec033ec852c7 Author: Biao She <bshe@chromium.org> Date: Thu Nov 23 15:58:17 2017 Wait until all results are received before navigate to search page for voice search Speech recognition engine might send multiple results which appear to be final results. Previously, once we received a final result, we initiate a search. This results strange issue like 785051. In this CL, we wait until SPEECH_RECOGNITION_END state (it is guarantted to be the last event for a speech session) received before decide if we should navigate to a search page. Bug: 785051 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I022fe06998bd69d7e689b72774dd6a557c1b0b2e Reviewed-on: https://chromium-review.googlesource.com/782401 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#518948} [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/speech_recognizer.cc [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/speech_recognizer.h [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/speech_recognizer_unittest.cc [delete] https://crrev.com/e89f5f9e232ef5f9e14345905b88eb1989d103d8/chrome/browser/vr/test/mock_browser_interface.cc [add] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/mock_browser_ui_interface.cc [add] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/mock_browser_ui_interface.h [add] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/mock_ui_browser_interface.cc [rename] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/mock_ui_browser_interface.h [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/ui_pixel_test.h [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/ui_scene_manager_test.cc [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/test/ui_scene_manager_test.h [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/ui_scene_manager_unittest.cc [modify] https://crrev.com/a9dc6e71746f2bcedca0757bc1e0ec033ec852c7/chrome/browser/vr/ui_unittest.cc
,
Nov 23 2017
,
Nov 29 2017
verified in 64.0.3279.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbbrooks@chromium.org
, Nov 14 2017