New issue
Advanced search Search tips

Issue 785044 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 469639



Sign in to add a comment

Integrate Origin Trials Framework for AudioWorklet

Project Member Reported by hongchan@chromium.org, Nov 14 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea

commit 9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea
Author: Hongchan Choi <hongchan@chromium.org>
Date: Tue Dec 05 00:53:35 2017

Integrate Origin Trial Framework for AudioWorklet with Metric

This patch adds 3 use counters for AudioWorket:
- AudioWorkletAddModule
- AudioWorkletGlobalScopeRegisterProcessor
- AudioWorkletNodeConstructor

Note that AudioWorklet.addModule() method is inherited from Worklet
class, so we cannot install the tracker via WebIDL. Instead, this CL
uses AudioWorklet::NeedsToCreateGlobalScope() check as a counter
trigger, which is invoked when Worklet.addModule() gets called.

Bug:  785044 
Change-Id: I7023b90b538a66003dcba3805592d692b1461eff
Reviewed-on: https://chromium-review.googlesource.com/770139
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521559}
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioParamMap.idl
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioWorklet.idl
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.idl
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.idl
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea/tools/metrics/histograms/enums.xml

Labels: Merge-Request-64
Status: Verified (was: Started)
This change requires https://chromium-review.googlesource.com/779862.
Please add affected OSs.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cd846f771139ea9ff278d2f65e4fccd3d29042

commit 91cd846f771139ea9ff278d2f65e4fccd3d29042
Author: Hongchan Choi <hongchan@chromium.org>
Date: Wed Dec 06 19:32:19 2017

Integrate Origin Trial Framework for AudioWorklet with Metric

This patch adds 3 use counters for AudioWorket:
- AudioWorkletAddModule
- AudioWorkletGlobalScopeRegisterProcessor
- AudioWorkletNodeConstructor

Note that AudioWorklet.addModule() method is inherited from Worklet
class, so we cannot install the tracker via WebIDL. Instead, this CL
uses AudioWorklet::NeedsToCreateGlobalScope() check as a counter
trigger, which is invoked when Worklet.addModule() gets called.

TBR=hongchan@chromium.org

(cherry picked from commit 9aabc4a91cb1c14a4b1cd1dc65903ec18487e2ea)

Bug:  785044 
Change-Id: I7023b90b538a66003dcba3805592d692b1461eff
Reviewed-on: https://chromium-review.googlesource.com/770139
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521559}
Reviewed-on: https://chromium-review.googlesource.com/810892
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#64}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioParamMap.idl
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioWorklet.idl
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioWorkletGlobalScope.idl
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/AudioWorkletProcessor.idl
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/Source/platform/runtime_enabled_features.json5
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/91cd846f771139ea9ff278d2f65e4fccd3d29042/tools/metrics/histograms/enums.xml

Sign in to add a comment