New issue
Advanced search Search tips

Issue 785022 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Suppress profile confirm dialog when force-sign-in is enabled.

Project Member Reported by zmin@chromium.org, Nov 14 2017

Issue description

This is a request from UI review of force-sign-in policy.

When force-sign-in is enabled, there is no need to show this dialog as only fresh profile s are allowed.
 

Comment 1 by zmin@chromium.org, Nov 14 2017

Owner: zmin@chromium.org
Status: (was: Untriaged)

Comment 2 by zmin@chromium.org, Nov 14 2017

Status: Started
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9053407a0934abb2bea99611ee9c9b5bd16503c3

commit 9053407a0934abb2bea99611ee9c9b5bd16503c3
Author: Owen Min <zmin@chromium.org>
Date: Wed Nov 15 19:45:45 2017

Suppress profile confirm dialog when force-sign-in is enabled.

Suppress the ProfileSigninConfirmationDialog when user sign
in with a corp account if force-sign-in is enabled. Because data
merge has been blocked before sign in started.
Also revert crrev.com/1dfa5cace005d124a5b34f91849e8d266fc37746 as
there is no need for that if the dialog is disabled.

Bug:  785022 
Change-Id: I89c5ab4b9bc21951c68b3f5f1da0a35b98ef30ea
Reviewed-on: https://chromium-review.googlesource.com/769738
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516792}
[modify] https://crrev.com/9053407a0934abb2bea99611ee9c9b5bd16503c3/chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Comment 4 by zmin@chromium.org, Nov 17 2017

Status: Fixed (was: Started)
Verified on Chrome canary 64.0.3271.0

Sign in to add a comment