New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785009 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[PhishGuard] Clean up TODOs and Tests

Project Member Reported by jialiul@chromium.org, Nov 14 2017

Issue description

Summary: [PhishGuard] Clean up TODOs and Tests (was: [PhishGuard] Clean up TODOs and dead code)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff010875f8288dbe2be31429bbf03a18d05283c

commit aff010875f8288dbe2be31429bbf03a18d05283c
Author: Jialiu Lin <jialiul@chromium.org>
Date: Thu Apr 19 19:51:36 2018

Add mock password protection service to simplify tests

Bug:  785009 
Change-Id: I13688afdc6cfd7c433595e31eb971cd1b288589c
Reviewed-on: https://chromium-review.googlesource.com/1018110
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552128}
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/chrome/test/BUILD.gn
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/components/safe_browsing/password_protection/BUILD.gn
[add] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/components/safe_browsing/password_protection/mock_password_protection_service.cc
[add] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/components/safe_browsing/password_protection/mock_password_protection_service.h
[modify] https://crrev.com/aff010875f8288dbe2be31429bbf03a18d05283c/components/safe_browsing/password_protection/password_protection_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment