New issue
Advanced search Search tips

Issue 785008 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 786591
issue 757607

Blocking:
issue 757605



Sign in to add a comment

Add about://gpu support for oop raster

Project Member Reported by enne@chromium.org, Nov 14 2017

Issue description

It's hard to know whether or not oop raster is enabled without printfs, since it's not on the about://gpu page.

This is currently complicated because oop raster can sometimes fail to be created even if requested.  This should be considered a bug and is due to skia and chrome having different ideas about blacklists.  Ideally, requesting oop raster would always turn on oop raster, which would make this a much easier task.

This is also blocked on  issue 757607 , because that will likely change how the context is created.
 
Components: Internals>GPU

Comment 2 by enne@chromium.org, Nov 17 2017

Blockedon: 786591

Comment 3 by enne@chromium.org, Jun 6 2018

Owner: backer@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339565ed443b3ac08d8d4162fe966ca318b95124

commit 339565ed443b3ac08d8d4162fe966ca318b95124
Author: Jonathan Backer <backer@chromium.org>
Date: Thu Jun 07 21:06:34 2018

Expose OOPR to chrome://gpu

Also a minor cleanup making GpuPreferences const.

TBR=boliu@chromium.org,tsepez@chromium.org

Bug:  785008 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I865682dc09a817a2d05a1ee9a410be5510f6bef9
Reviewed-on: https://chromium-review.googlesource.com/1091072
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565406}
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/android_webview/browser/deferred_gpu_command_service.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/components/viz/service/gl/gpu_service_impl.h
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/content/browser/resources/gpu/info_view.js
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/command_buffer/tests/gl_test_utils.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_blacklist_unittest.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector.h
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_android.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_fuchsia.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_linux.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_mac.mm
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_unittest.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_info_collector_win.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_util.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/config/gpu_util.h
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/339565ed443b3ac08d8d4162fe966ca318b95124/gpu/ipc/service/gpu_init.cc

Comment 6 by backer@chromium.org, Jun 11 2018

Status: Fixed (was: Started)
I'm calling this fixed. It's exposed and seems to be WAI based on my manual tests.

Sign in to add a comment