New issue
Advanced search Search tips

Issue 785001 link

Starred by 3 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Sep 21
Cc:
foolip@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The document background color reported to the browser process doesn't account for HTML5 fullscreen

Project Member Reported by sdy@chromium.org, Nov 14 2017 
Chrome Version: 64.0.3265.0
OS: *, but tested on macOS 10.12.6

What steps will reproduce the problem?
(1) Load the attached HTML file, which has a video element inside a div.
(2) Follow the instructions to have the div request fullscreen and then resize the window.

What is the expected result?
The background color shown by the browser should reflect the actual document background color (which defaults to black when an element is fullscreen).

What happens instead?
The renderer draws a black background, but the browser still has the top-level document's background color, which may be different (and defaults to white), so anything which reveals the background (like resizing the window while in HTML5 fullscreen) reveals a mismatched background color.
full_screen_background.jpg
129 KB View Download
full_screen_background.mp4
659 KB View Download
full_screen_background.html
26.9 KB View Download

Comment 1 by chrishtr@chromium.org, Nov 15 2017 

I don't think this is a bug. The root issue is that the gutter area during resize of a page defaults
to the background color of the page. But if the background color of a page disagrees with the
dominant color of content showing within the page, it won't look great because the gutter color
will disagree with the dominant color.

Web pages can easily optimize their guttering by supplying or dynamically updating their background
colors. I gave similar advice a few days ago for the issue of white flashing during page navigation -
the right fix is for web developers to specify a good background color.

I don't think fullscreen is an important enough use case on its own to justify special color plumbing
to the compositor during resize, as resize is not a common operation for the fullsize. (Much much
less common than maximize/minimize.)

Comment 2 by chrishtr@chromium.org, Nov 15 2017 

s/I don't think this is a bug/I don't think this is important enough to be
worth fixing/

Sorry for the misstatement.

Comment 3 by cbiesin...@chromium.org, Nov 27 2017

Cc: foolip@chromium.org
Status: Available (was: Untriaged)

Comment 4 by dtapu...@chromium.org, Aug 28 

sdy@ can you still reproduce this? I tried and I cannot.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ee8b41fba2e41aa0b599ac63a0087356f306c31

commit 5ee8b41fba2e41aa0b599ac63a0087356f306c31
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Fri Sep 21 15:29:42 2018

Avoid a flash when the fullscreen element is sometimes resized.

The background can be painted underneath occasionally. When we have
a fullscreen element indicate the backdrop's color.

BUG=886544,  785001 

Change-Id: I17d2533779abc68b14bc8af732f182dd32e963f0
Reviewed-on: https://chromium-review.googlesource.com/1234232
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593193}
[modify] https://crrev.com/5ee8b41fba2e41aa0b599ac63a0087356f306c31/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/5ee8b41fba2e41aa0b599ac63a0087356f306c31/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/5ee8b41fba2e41aa0b599ac63a0087356f306c31/third_party/blink/renderer/core/testing/data/fullscreen_style.html

Comment 6 by dtapu...@chromium.org, Sep 21

Owner: dtapu...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment