New issue
Advanced search Search tips

Issue 784994 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

waveshaper-limit tests uses detached AudioBuffer

Project Member Reported by rtoy@chromium.org, Nov 14 2017 
In waveshaper-limits.html, we end up using a detached Float32Array for
comparing the actual output to the expected output.  Don't do this.
Fixing this will allow this test to run on Firefox which detaches
AudioBuffers that are assigned to sources.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f507edbaaf341d36f39a9efc5259b0b2eeab85

commit 64f507edbaaf341d36f39a9efc5259b0b2eeab85
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Nov 14 22:41:27 2017

Remove use of detached AudioBuffer.

Instead of initializing the contents of an AudioBuffer directly and
then expecting to be able to use it for comparison later, just create
a new array and initialize it separately.  Then copy it to the
AudioBuffer.

As required by the spec, starting an AudioBufferSource detaches the
any copies of the AudioBuffer, including the one we used to initialize
the AudioBuffer.

Bug:  784994 
Test: WaveShaper/waveshaper-limits.html
Change-Id: I14275914a3c15d7d9d8fca0f5772d66e15b8f752
Reviewed-on: https://chromium-review.googlesource.com/769847
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516472}
[modify] https://crrev.com/64f507edbaaf341d36f39a9efc5259b0b2eeab85/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html

Comment 2 by rtoy@chromium.org, Nov 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment