New issue
Advanced search Search tips

Issue 784967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3% regression in speedometer at 516100:516200

Project Member Reported by tdres...@chromium.org, Nov 14 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 14 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=784967

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=59619c843fc345cd14af2f7acca9ad0fda93df01847319c620495007f5a3161a


Bot(s) for this bug's original alert(s):

android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 14 2017

Cc: keishi@chromium.org
Owner: keishi@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author keishi@chromium.org ===

Hi keishi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Keishi Hattori
  Commit : 99f46d3e60fcc50776619bc69b459e54f4ca8e2d
  Date   : Tue Nov 14 02:26:40 2017
  Subject: Oilpan: Add magic number to BasePage

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total
  Change       : 2.81% | 40800.6905556 -> 41946.4619444

Revision             Result                  N
chromium@516099      40800.7 +- 531.012      6      good
chromium@516125      41116.3 +- 511.735      6      good
chromium@516138      40905.8 +- 936.508      6      good
chromium@516144      41011.7 +- 483.875      6      good
chromium@516147      40879.9 +- 521.894      6      good
chromium@516148      40968.6 +- 313.032      6      good
chromium@516149      42090.3 +- 430.58       6      bad       <--
chromium@516150      42090.1 +- 325.298      6      bad
chromium@516200      41946.5 +- 605.693      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962922804384222864


For feedback, file a bug with component Speed>Bisection

Comment 4 by keishi@chromium.org, Nov 15 2017

Status: Started (was: Assigned)
Reverted r516149
https://chromium-review.googlesource.com/c/chromium/src/+/770670
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 15 2017

 Issue 784963  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 16 2017

 Issue 785736  has been merged into this issue.
Thanks, keishi! Can we mark this as fixed?
Status: Fixed (was: Started)
The regression is gone.

Sign in to add a comment