https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64538

In theory none of Brett's changed should have impacted core logic, and I haven't directly touched dragging recently.

Is the failure new, or has this test been flaky for a while on linux? Tom has done changes to window decorations, but I would be surprised if those are impacting this.

PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification is flaking recently.
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64634
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64607
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64597
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64581

Disabling PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification, but taking no action on TabDragging/DetachToBrowserTabDragControllerTest.DragToSeparateWindow/0 since it hasn't failed since Nov 14.

awdf@: You have touched PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification recently. Can you take a look or find a better owner?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1016b760146885abb36fca61ea36d45c630d8b61

commit 1016b760146885abb36fca61ea36d45c630d8b61
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Nov 17 10:28:53 2017

Disable flaky PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification on Linux

TBR=dimich@chromium.org

Bug:  784951 
Change-Id: If7f4533c7712230b0a8b0cd12e869599e67b6eea
Reviewed-on: https://chromium-review.googlesource.com/776713
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517359}
[modify] https://crrev.com/1016b760146885abb36fca61ea36d45c630d8b61/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

Failure log:

[ RUN      ] PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification
Xlib:  extension "RANDR" missing on display ":99".
[27983:28024:1116/191850.204343:ERROR:bus.cc(395)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[27983:27983:1116/191850.206531:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[27983:27984:1116/191850.332943:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../base/test/histogram_tester.cc:40: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "Notifications.PersistentWebNotificationCloseResult" does not exist.
[27983:27983:1116/191850.385029:INFO:chrome_cryptauth_service.cc(222)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] PlatformNotificationServiceBrowserTest.UserClosesPersistentNotification, where TypeParam =  and GetParam() =  (806 ms)

I can reproduce the flake locally on 1-2% of runs, by running it 100x with the following command (and scrolling up the results):

$ nice ninja -C out/LinuxDebug -j2000 -l20 interactive_ui_tests && xvfb-run -s "-screen 0 1024x768x24" out/LinuxDebug/interactive_ui_tests --gtest_filter="*PlatformNotificationServiceBrowserTest.UserClosesPersistent*" --extract-test-list-from-filter --test-launcher-bot-mode --gtest_repeat=100

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64337af3fa6a5ed60960b65a70ca8ba060483cc4

commit 64337af3fa6a5ed60960b65a70ca8ba060483cc4
Author: Peter Beverloo <peter@chromium.org>
Date: Tue Nov 21 18:04:02 2017

Let Notification Handlers report when event handling has completed

This will significantly help reduce flakiness in testing (one deflake
included in this CL), and is required for migrating Android's intent
handling system to the BackgroundTaskScheduler which needs to know when
handling of the event has finished.

In addition, a hack where the NativeNotificationDisplayService invoked
the Close() method on a notification's delegate in order to fire the
event for non-persistent Web Notifications has been removed. We can just
fire the event from the NotificationMessageFilter instead.

BUG=766854,  784951 

Change-Id: I57d0a446e6c47281bb7b5e001c449fadddeba571
Reviewed-on: https://chromium-review.googlesource.com/779722
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518305}
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/BUILD.gn
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/download/notification/download_notification_manager.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/extensions/api/notifications/extension_notification_handler.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/extensions/api/notifications/extension_notification_handler.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/extensions/api/notifications/extension_notification_handler_unittest.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/native_notification_display_service.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/non_persistent_notification_handler.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/non_persistent_notification_handler.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/notification_display_service.cc
[add] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/notification_handler.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/notification_handler.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/persistent_notification_handler.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/persistent_notification_handler.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/platform_notification_service_impl.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/platform_notification_service_unittest.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/notifications/stub_notification_display_service.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/chrome/browser/push_messaging/push_messaging_notification_manager.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/content/browser/notifications/notification_event_dispatcher_impl.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/content/browser/notifications/notification_event_dispatcher_impl.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/content/browser/notifications/notification_message_filter.cc
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/content/public/browser/notification_event_dispatcher.h
[modify] https://crrev.com/64337af3fa6a5ed60960b65a70ca8ba060483cc4/content/test/mock_platform_notification_service.cc

No more flakes in the past few days, so yay.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50f4576e3a1145abea9a2f7fc77c7c4bd6caea66

commit 50f4576e3a1145abea9a2f7fc77c7c4bd6caea66
Author: Danyao Wang <danyao@chromium.org>
Date: Wed Jan 03 00:34:11 2018

[Nav Experiment] Load placeholder URL in |loadErrorInNativeView:|.

Native error view is triggered when a pending item can't be loaded due
to network error. It is handled by commiting the pending item and
activating the native controller. With WKBasedNavigationManager, the
commit step needs a WKBackForwardListItem in order to commit the pending
item. Injecting a placeholder URL into WKWebView fixes this problem.

Because any URL can trigger a native error view, I also removed the
assertions checking that the URL encoded in a placeholder URL is always
an app-specific URL.

This fixes the following egtest failures:
TabUsageRecorderTest/testOpenFromApp
NavigationTestCase/testHistoryForwardToErrorPage
NavigationTestCase/testHistoryBackNavigation
NavigationTestCase/testWindowLocationReplaceAndChangeHash

Bug:  784951 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie4f61087301774340981ba3661740b1f4e103a1e
Reviewed-on: https://chromium-review.googlesource.com/847907
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526553}
[modify] https://crrev.com/50f4576e3a1145abea9a2f7fc77c7c4bd6caea66/ios/web/web_state/ui/crw_web_controller.mm

Oops sorry I added the wrong bug to crrev.com/c/847907. It refers to  crbug.com/784915 .

Sorry for causing spam here.