New issue
Advanced search Search tips

Issue 784945 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Merge files in ash/mus with rest of ash

Project Member Reported by sky@chromium.org, Nov 14 2017

Issue description

Given we hope to make --mus the default soon, keeping all the mus related files in their own directory doesn't make a lot of sense. They should instead be folded in with the rest of ash. Here's my plan:

ash/accelerators gets:
ash/mus/accelerators/accelerator_controller_delegate_mus.cc
ash/mus/accelerators/accelerator_controller_delegate_mus.h
ash/mus/accelerators/accelerator_controller_registrar.cc
ash/mus/accelerators/accelerator_controller_registrar.h
ash/mus/accelerators/accelerator_handler.h
ash/mus/accelerators/accelerator_ids.h

ash/display gets:
ash/mus/display_synchronizer*

ash/frame gets:
ash/mus/frame/detached_title_area_renderer*

ash/host gets:
ash/mus/ash_window_tree_host_mus*

ash/keyboard gets:
ash/mus/keyboard_ui_mus.*

ash/touch:
ash/mus/touch_transform_setter_mus*

ash/wallpaper:
ash/mus/wallpaper_delegate_mus**

ash/wm gets:
ash/mus/bridge/immersive_handler_factory_mus*
ash/mus/drag_window_resizer*
ash/mus/move_event_handler*
ash/mus/non_client_frame_controller.* (this could potentially live in ash/frame as well, but this is more about controlling that actual frame drawing)
ash/mus/property_util.*
ash/mus/shell_delegate_mus*
ash/mus/top_level_window_factory.*
Move contents of ash/mus/window_properties.h into ash/wm/window_properties.h

ash/wm/workspace gets:
ash/mus/bridge/workspace_event_handler_mus*

ash/ gets:
ash/mus/bridge/shell_port_mash*
ash/mus/shell_port_mus*
ash/mus/disconnected_app_handler*
ash/mus/network_connect_delegate_mus*
Rename ash/mus/window_manager_application. to WindowManagerServer and move
ash/mus/window_manager*
ash/mus/event_matcher_util*

Move ash/mus/standalone to ash/standalone

I will also remove the ash::mus namespace and rename any files/names ending in mus that are mash specific to mash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eda33e3ce6109151a31396cce021e4ab0798aa3

commit 6eda33e3ce6109151a31396cce021e4ab0798aa3
Author: Scott Violet <sky@chromium.org>
Date: Tue Nov 14 23:53:37 2017

chromeos: renames WindowManagerApplication to WindowManagerService

BUG= 784945 
TEST=straight rename

Change-Id: I3917dfcc51e4e574fb9821e738037e20e898e666
Reviewed-on: https://chromium-review.googlesource.com/769292
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516508}
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/BUILD.gn
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/main.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/standalone/ash_standalone_main.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/top_level_window_factory_unittest.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/window_manager.cc
[rename] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/window_manager_service.cc
[rename] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/window_manager_service.h
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/test/ash_test_base.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/test/ash_test_helper.cc
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/ash/test/ash_test_helper.h
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/chrome/utility/DEPS
[modify] https://crrev.com/6eda33e3ce6109151a31396cce021e4ab0798aa3/chrome/utility/mash_service_factory.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58ae95b37b7b3cc6433833a224b426ab51824cf1

commit 58ae95b37b7b3cc6433833a224b426ab51824cf1
Author: Scott Violet <sky@chromium.org>
Date: Wed Nov 15 06:25:53 2017

chromeos: removes ash::mus namespace and merges with ash

BUG= 784945 
TEST=no functional changes

Change-Id: I4302d536e83310d1b09eeba92d5e0a2210406f99
Reviewed-on: https://chromium-review.googlesource.com/769752
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516612}
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/BUILD.gn
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_controller_delegate_mus.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_controller_registrar.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_controller_registrar.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_handler.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/accelerators/accelerator_ids.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/app_launch_unittest.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/immersive_handler_factory_mus.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/immersive_handler_factory_mus.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/shell_port_mash.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/workspace_event_handler_mus.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/bridge/workspace_event_handler_mus.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/disconnected_app_handler.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/disconnected_app_handler.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/display_synchronizer_unittest.cc
[rename] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/drag_window_resizer_mash.cc
[rename] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/drag_window_resizer_mash.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/frame/detached_title_area_renderer.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/frame/detached_title_area_renderer.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/main.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/move_event_handler.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/move_event_handler.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/network_connect_delegate_mus.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/network_connect_delegate_mus.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/non_client_frame_controller.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/non_client_frame_controller.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/property_util.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/property_util.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/shell_port_mus.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/shell_port_mus.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/standalone/ash_standalone_main.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/top_level_window_factory.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/top_level_window_factory.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/top_level_window_factory_unittest.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager_common_unittests.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager_service.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager_service.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_properties.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/mus/window_properties.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/root_window_controller.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/test/ash_test_base.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/test/ash_test_helper.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/ash/test/ash_test_helper.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/chrome/browser/ui/ash/ash_init.h
[modify] https://crrev.com/58ae95b37b7b3cc6433833a224b426ab51824cf1/chrome/utility/mash_service_factory.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5de121fa84422a9c99659d526228febbcbd0793

commit f5de121fa84422a9c99659d526228febbcbd0793
Author: Scott Violet <sky@chromium.org>
Date: Thu Nov 16 00:43:10 2017

chromeos: renames mash specific files to mash

BUG= 784945 
TEST=no functional changes

Change-Id: I7f00b4fbdb33201f3be2a6a7156d4c0126c84e39
Reviewed-on: https://chromium-review.googlesource.com/772962
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516919}
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/BUILD.gn
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/accelerators/accelerator_controller_delegate_mash.cc
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/accelerators/accelerator_controller_delegate_mash.h
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/immersive_handler_factory_mash.cc
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/immersive_handler_factory_mash.h
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/shell_port_mash.cc
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/shell_port_mash.h
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/workspace_event_handler_mash.cc
[add] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/bridge/workspace_event_handler_mash.h
[delete] https://crrev.com/f4571479cece3b0bd70653692f5240a0866950d0/ash/mus/bridge/workspace_event_handler_mus.h
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/keyboard_ui_mash.cc
[rename] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/keyboard_ui_mash.h
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/move_event_handler.cc
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/move_event_handler.h
[modify] https://crrev.com/f5de121fa84422a9c99659d526228febbcbd0793/ash/mus/shell_port_mus.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c79b0d53d2282f382630f458f45cdca47b5eb23

commit 4c79b0d53d2282f382630f458f45cdca47b5eb23
Author: Scott Violet <sky@chromium.org>
Date: Fri Nov 17 21:47:13 2017

chromeos: moves ash/mus files into ash

The only ick in this patch is allowing circular deps on wayland and
exo. This is necessary because WindowManagerService includes wayland,
wayland includes ash...

BUG= 784945 
TEST=no functional changes
TBR=tsepez@chromium.org

Change-Id: If62836861c7db7e0af62cea4a3b8c18fb2aa4675
Reviewed-on: https://chromium-review.googlesource.com/775579
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517569}
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/DEPS
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/OWNERS
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/README.md
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_controller_delegate_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_controller_delegate_mash.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_controller_registrar.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_controller_registrar.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_handler.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/accelerators/accelerator_ids.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/app_launch_unittest.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/disconnected_app_handler.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/disconnected_app_handler.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/display/display_synchronizer.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/display/display_synchronizer.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/display/display_synchronizer_unittest.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/event_matcher_util.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/event_matcher_util.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/frame/detached_title_area_renderer.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/frame/detached_title_area_renderer.h
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/host/DEPS
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/host/ash_window_tree_host_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/host/ash_window_tree_host_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/keyboard/keyboard_ui_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/keyboard/keyboard_ui_mash.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/main.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/manifest.json
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/BUILD.gn
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/DEPS
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/OWNERS
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/bridge/README.md
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/frame/README.md
[delete] https://crrev.com/470e75ba6e4f92d4a4123673fa667be9a0f10076/ash/mus/test/DEPS
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/network_connect_delegate_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/network_connect_delegate_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_delegate_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_delegate_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_port_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_port_mash.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_port_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/shell_port_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/standalone/BUILD.gn
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/standalone/OWNERS
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/standalone/README.md
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/standalone/ash_standalone_main.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/standalone/manifest.json
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/test/ash_test_base.cc
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/test/ash_test_helper.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/touch/touch_transform_setter_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/touch/touch_transform_setter_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wallpaper/wallpaper_delegate_mus.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wallpaper/wallpaper_delegate_mus.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager_common_unittests.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager_service.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager_service.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/window_manager_unittest.cc
[add] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/DEPS
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/drag_window_resizer_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/drag_window_resizer_mash.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/immersive_handler_factory_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/immersive_handler_factory_mash.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/move_event_handler.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/move_event_handler.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/non_client_frame_controller.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/non_client_frame_controller.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/non_client_frame_controller_unittest.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/property_util.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/property_util.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/top_level_window_factory.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/top_level_window_factory.h
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/top_level_window_factory_unittest.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/workspace/workspace_event_handler_mash.cc
[rename] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/ash/wm/workspace/workspace_event_handler_mash.h
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/app/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/test/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/utility/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/utility/DEPS
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/components/exo/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/mash/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/mash/example/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/mash/session/BUILD.gn
[modify] https://crrev.com/4c79b0d53d2282f382630f458f45cdca47b5eb23/mash/test/mash_test_suite.cc

Comment 6 by sky@chromium.org, Nov 17 2017

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment