New issue
Advanced search Search tips

Issue 784933 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Separate out HTTP and transport RTT observation buffers

Project Member Reported by tbansal@chromium.org, Nov 14 2017 
Currently, Network Quality Estimator (NQE) stores RTT observations from HTTP layer and transport layer in the same container. Due to the limited size of the container, this can sometimes lead to transport layer observations completely evicting the HTTP RTT observations from the buffer. This is undesirable since HTTP RTT observations are needed for generating the HTTP later RTT estimate.

One possible solution is to store the HTTP RTT observations in a different container than the transport RTT observations.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27269dc409a6f6ff0ac081371964d29bdc05712f

commit 27269dc409a6f6ff0ac081371964d29bdc05712f
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Nov 15 18:33:52 2017

Network quality estimator: Separate out observation buffer for
HTTP RTT observations from transport RTT observations.

Bug:  784933 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2d638653d87e6c1c2a1d7b2ede965ad420abc0cb
Reviewed-on: https://chromium-review.googlesource.com/769151
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516755}
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_observation.cc
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_observation.h
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/network_quality_observation_source.h
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/observation_buffer.cc
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/observation_buffer.h
[modify] https://crrev.com/27269dc409a6f6ff0ac081371964d29bdc05712f/net/nqe/observation_buffer_unittest.cc

Comment 2 by tbansal@chromium.org, Nov 16 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed0c59941182ce9bf96afce297331995b0720ede

commit ed0c59941182ce9bf96afce297331995b0720ede
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Nov 17 03:23:50 2017

Enforce the correctness of ordering of observations in Network Quality Estimator

Enforce that the observations are added to the observation buffer in
non-decreasing order of timestamps.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug:  784933 
Change-Id: I24d5a9c5165d841ad32304d35b146012697575a1
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/772078
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517275}
[modify] https://crrev.com/ed0c59941182ce9bf96afce297331995b0720ede/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/ed0c59941182ce9bf96afce297331995b0720ede/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/ed0c59941182ce9bf96afce297331995b0720ede/net/nqe/observation_buffer.cc
►

Sign in to add a comment