New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784913 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 718811



Sign in to add a comment

Thumbnails: Improve UMA coverage

Project Member Reported by treib@chromium.org, Nov 14 2017

Issue description

Currently thumbnail capturing has very limited UMA coverage. Some things we might want to add:
- How it was triggered (tab hidden vs. navigating).
- Result: success, failed capture, discarded capture (new doc arrived in the meantime), couldn't start (doc hasn't painted yet); probably split by trigger.
 

Comment 1 by mastiz@chromium.org, Nov 14 2017

Labels: -Type-Bug zine-triaged Type-Feature

Comment 2 by treib@chromium.org, Nov 20 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733698392bf69baced378ebbacf8318c6c82a16e

commit 733698392bf69baced378ebbacf8318c6c82a16e
Author: Marc Treib <treib@chromium.org>
Date: Fri Nov 24 10:11:02 2017

Thumbnail capturing: Add UMA histograms for the outcome

This adds a histogram Thumbnails.CaptureOutcome, plus a split in
.TabHidden vs .NavigatingAway.

Bug:  784913 
Change-Id: Ic2b9d44ccb1f13592a69ef1df6d6918b0b2471f8
Reviewed-on: https://chromium-review.googlesource.com/779263
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519078}
[modify] https://crrev.com/733698392bf69baced378ebbacf8318c6c82a16e/chrome/browser/thumbnails/thumbnail_tab_helper.cc
[modify] https://crrev.com/733698392bf69baced378ebbacf8318c6c82a16e/chrome/browser/thumbnails/thumbnail_tab_helper.h
[modify] https://crrev.com/733698392bf69baced378ebbacf8318c6c82a16e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/733698392bf69baced378ebbacf8318c6c82a16e/tools/metrics/histograms/histograms.xml

Comment 4 by treib@chromium.org, Nov 24 2017

Status: Fixed (was: Started)

Sign in to add a comment