New issue
Advanced search Search tips

Issue 784910 link

Starred by 1 user
Status: Fixed
Owner:
zmin@chromium.org
Closed: Nov 2017
Cc:
georgesak@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Do not display welcome page when Chrome is launched with force-sign-in enabled.

Project Member Reported by zmin@chromium.org, Nov 14 2017 
This is a request from UI review of force-sign-in policy.

When user login into a new profile with force-sign-in policy enabled, Chrome should not show the welcome page that ask user to signin. Because user has been forced to sign in before browser window is opened.

In the mean time, welcome page for Win10 won't be changed as it's related to default browser setup.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f7c8e51cc81951fd12d2154db7bdcc95f2da91

commit 26f7c8e51cc81951fd12d2154db7bdcc95f2da91
Author: Owen Min <zmin@chromium.org>
Date: Wed Nov 15 18:00:30 2017

Disable welcome page when force-sign-in is enabled

There is no need to show the welcome page that asks user to sign in
when force-sign-in is enabled.

Bug:  784910 
Change-Id: I953350fabc94f06a5facc8f8cc345a4f0a7fbd44
Reviewed-on: https://chromium-review.googlesource.com/769829
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516742}
[modify] https://crrev.com/26f7c8e51cc81951fd12d2154db7bdcc95f2da91/chrome/browser/ui/startup/startup_tab_provider.cc
[modify] https://crrev.com/26f7c8e51cc81951fd12d2154db7bdcc95f2da91/chrome/browser/ui/startup/startup_tab_provider.h
[modify] https://crrev.com/26f7c8e51cc81951fd12d2154db7bdcc95f2da91/chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Comment 2 by georgesak@chromium.org, Nov 15 2017

Status: Started (was: Untriaged)

Comment 3 by zmin@chromium.org, Nov 17 2017

Status: Fixed (was: Started)
Verified on Chrome canary 64.0.3271.0
►

Sign in to add a comment