New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 784880 link

Starred by 1 user
Status: Fixed
Owner:
█ ethannicholas@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28kb regression in resource_sizes (MonochromePublic.apk) at 516000:516000

Project Member Reported by agrieve@chromium.org, Nov 14 2017 
Caused by “sksl enum support”

Skia Commit: aae47c878b83ab6d9742d92a6fa47e762f6b9204
Rolled in: e6eb32fc22a8ba0bc2765e38a5b5678855d86744

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev= 516000

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

It's not clear to me whether or not this increase was expected.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 14 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=784880

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1078a26b327c5d5a9fbfdf4cab099f9ed13e7d05d731978f3c7c3b23156f4b3f


Bot(s) for this bug's original alert(s):

Android Builder

Comment 2 by agrieve@chromium.org, Nov 14 2017 

Supersize diff:

.text=3.52kb     .rodata=23.0kb     .data.rel.ro=32 bytes   .data=0 bytes    .bss=0 bytes    total=26.6kb
Number of unique paths: 13

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)      28415 (104.0%) r@0x2925da1  28415 (542->28957) third_party/skia/src/sksl/SkSLCompiler.cpp
               string literal
~ 1)      20482 (75.0%) r@0x292cf19  -7933 (8237->304)  third_party/skia/src/sksl/SkSLCompiler.cpp
               string literal
+ 2)      23606 (86.4%) t@0x6bf9e0   3124 (0->3124)     third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::convertFunction
- 3)      20518 (75.1%) t@0x0        -3088 (3088->0)    third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::convertFunction
~ 4)      22227 (81.3%) r@0x292d5d2  1709 (220->1929)   third_party/skia/src/sksl/SkSLCompiler.cpp
               string literal
+ 5)      23775 (87.0%) t@0x6bed64   1548 (0->1548)     third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::applyInvocationIDWorkaround
- 6)      22227 (81.3%) t@0x0        -1548 (1548->0)    third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::applyInvocationIDWorkaround
+ 7)      23519 (86.1%) t@0x6c9044   1292 (0->1292)     third_party/skia/src/sksl/SkSLParser.cpp
               SkSL::Parser::enumDeclaration
+ 8)      24593 (90.0%) t@0x6c1354   1074 (0->1072)     third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::convertEnum
+ 9)      25045 (91.7%) t@0x6c54a8   452 (0->452)       third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::IRGenerator::convertTypeField
~ 10)     25458 (93.2%) r@Group      413 (22727->23140) third_party/skia/src/sksl/SkSLLayoutLexer.cpp
               SkSL::transitions (count=2)
~ 11)     25871 (94.7%) r@Group      413 (22727->23140) third_party/skia/src/sksl/SkSLLexer.cpp
               SkSL::transitions (count=2)
+ 12)     26231 (96.0%) t@0x6c6ff4   360 (0->360)       third_party/skia/src/sksl/SkSLIRGenerator.cpp
               SkSL::Enum::description const
~ 13)     25910 (94.8%) t@Group      -321 (0->0)        {{no path}}
               ** symbol gaps (count=9)
+ 14)     26162 (95.7%) t@0x6ceb1c   252 (0->252)       third_party/skia/src/sksl/SkSLParser.cpp
               SkSL::ASTEnum::description const
+ 15)     26400 (96.6%) t@0x608384   238 (0->236)       third_party/skia/src/gpu/GrContext.cpp
               GrConfigConversionEffect::Make
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/7970765f7db5919ef5c6ad04b1a1bfe6505355c6

commit 7970765f7db5919ef5c6ad04b1a1bfe6505355c6
Author: Ethan Nicholas <ethannicholas@google.com>
Date: Thu Nov 16 17:52:42 2017

Switched SkSL from using raw strings back to STRINGIFY

Stringify was stripping the comments from the strings, whereas raw
strings preserve them, which led to an increase in executable
size. The only effect of this change is to strip the comments back
out.

Bug:  784880 
Change-Id: Icf2f9cf522cb890179f2e481a3504e8171732705
Reviewed-on: https://skia-review.googlesource.com/72524
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/gn/create_sksl_enums.py
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/sksl_geom.include
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/sksl_frag.include
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/sksl.include
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/SkSLCompiler.cpp
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/sksl_fp.include
[modify] https://crrev.com/7970765f7db5919ef5c6ad04b1a1bfe6505355c6/src/sksl/sksl_vert.include
►

Sign in to add a comment