Issue metadata
Sign in to add a comment
|
pobfuzz: SkTextBlob::Deserialize -> SkPaint::unflatten heap-buffer-overflow |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6539942556860416 Fuzzer: libFuzzer_paint_op_buffer_fuzzer Job Type: libfuzzer_chrome_asan Platform Id: linux Crash Type: Heap-buffer-overflow READ 4 Crash Address: 0x607000001258 Crash State: SkReader32::readScalar SkPaint::unflatten SkTextBlob::MakeFromBuffer Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=515040:515064 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6539942556860416 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
,
Nov 14 2017
,
Nov 14 2017
,
Nov 14 2017
,
Nov 14 2017
,
Nov 14 2017
The problem here is that the buffer isn't big enough to contain SkPaint, so deserialization fails. We could ensure that the buffer is "big enough", but I'm unsure what big enough would be here. Even so, I think this problem can still occur in the middle of the buffer. I think there needs to be a failure mode in Skia.
,
Nov 15 2017
,
Nov 15 2017
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15 2017
,
Nov 15 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/e84b482b763e2e2f39722b495e24c82b4859dc8c commit e84b482b763e2e2f39722b495e24c82b4859dc8c Author: Mike Reed <reed@google.com> Date: Wed Nov 15 17:31:46 2017 use validating readbuffer Bug:784869 Change-Id: Iaf43e14ec2ad72d061e7de25364fb481229d7651 Reviewed-on: https://skia-review.googlesource.com/71764 Commit-Queue: Mike Reed <reed@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> [modify] https://crrev.com/e84b482b763e2e2f39722b495e24c82b4859dc8c/src/core/SkTextBlob.cpp
,
Nov 16 2017
ClusterFuzz has detected this issue as fixed in range 516771:516815. Detailed report: https://clusterfuzz.com/testcase?key=6539942556860416 Fuzzer: libFuzzer_paint_op_buffer_fuzzer Job Type: libfuzzer_chrome_asan Platform Id: linux Crash Type: Heap-buffer-overflow READ 4 Crash Address: 0x607000001258 Crash State: SkReader32::readScalar SkPaint::unflatten SkTextBlob::MakeFromBuffer Sanitizer: address (ASAN) Recommended Security Severity: Medium Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=515040:515064 Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=516771:516815 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6539942556860416 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Nov 16 2017
ClusterFuzz testcase 6539942556860416 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Nov 16 2017
,
Feb 22 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
,
Mar 31 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ClusterFuzz
, Nov 14 2017Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)