New issue
Advanced search Search tips

Issue 784862 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

CHECK failure: size <= kMaxRegularHeapObjectSize in runtime-internal.cc

Project Member Reported by ClusterFuzz, Nov 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5458811845607424

Fuzzer: v8_builtins_generator
Job Type: linux_msan_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  size <= kMaxRegularHeapObjectSize in runtime-internal.cc
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_d8&range=49342:49343

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5458811845607424

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 14 2017

Labels: Test-Predator-Auto-Owner
Owner: peter.wm...@gmail.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/c5c50e18600db409d13efff6a33ae65062de4fe1 ([builtins] Port WeakMap/WeakSet constructor to CSA).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by mmoroz@chromium.org, Nov 14 2017

Owner: ----
Status: Unconfirmed (was: Assigned)
Removing the owner so V8 sheriff can triage that.
Cc: peter.wm...@gmail.com
Owner: jgruber@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to reviewer and moving author to cc.
My bad, I missed that during review. We need to pass kAllowLargeObjectAllocation to CSA::AllocateJSObjectFromMap. Peter, want to take care of this?

Comment 5 by mmoroz@chromium.org, Nov 15 2017

Labels: Security_Impact-Head M-63

Comment 6 by mmoroz@chromium.org, Nov 15 2017

Labels: -M-63 M-64
Correction: The culprit call isn't AllocateJSObjectFromMap but AllocateFixedArray (that makes more sense). Got a fix in flight.
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/271ffdb0f7b780f2df61202398fdc0e435e04102

commit 271ffdb0f7b780f2df61202398fdc0e435e04102
Author: Jakob Gruber <jgruber@chromium.org>
Date: Wed Nov 15 12:08:35 2017

[collections] Allocate large collections in large object space

The backing store fixed array for collections needs to be allocated
in LOS if it exceeds the maximum regular heap object size.

Drive-by-fix: Only store fixed array map once as per TODO.

Bug:  chromium:784862 
Change-Id: I6b4dd2e45153ae107171e21bc7448e0d9b54b0ed
Reviewed-on: https://chromium-review.googlesource.com/771150
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49378}
[modify] https://crrev.com/271ffdb0f7b780f2df61202398fdc0e435e04102/src/builtins/builtins-collections-gen.cc
[modify] https://crrev.com/271ffdb0f7b780f2df61202398fdc0e435e04102/src/code-stub-assembler.cc
[modify] https://crrev.com/271ffdb0f7b780f2df61202398fdc0e435e04102/src/debug/debug-evaluate.cc
[add] https://crrev.com/271ffdb0f7b780f2df61202398fdc0e435e04102/test/mjsunit/regress/regress-784862.js

Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 15 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by ClusterFuzz, Nov 16 2017

ClusterFuzz has detected this issue as fixed in range 49377:49378.

Detailed report: https://clusterfuzz.com/testcase?key=5458811845607424

Fuzzer: v8_builtins_generator
Job Type: linux_msan_d8
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  size <= kMaxRegularHeapObjectSize in runtime-internal.cc
  
Sanitizer: memory (MSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_d8&range=49342:49343
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_d8&range=49377:49378

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5458811845607424

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Nov 16 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5458811845607424 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 28

Labels: Pri-1

Sign in to add a comment