New issue
Advanced search Search tips

Issue 784861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword is flaky

Project Member Reported by jdoerrie@chromium.org, Nov 14 2017

Issue description

PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword appears to be flaky, causing (among others) renderer_side_navigation_interactive_ui_tests to fail on multiple platforms.

Builders failed on: 
- Linux Tests: 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests


Flakiness Dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=renderer_side_navigation_interactive_ui_tests&showExpectations=true&tests=PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword

Assigning to kolos@ to further investigate.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47be7de585bb807028571c4bc9d2507d853e58bb

commit 47be7de585bb807028571c4bc9d2507d853e58bb
Author: Luna Lu <loonybear@chromium.org>
Date: Wed Nov 15 21:38:14 2017

Disable AutoSavingGeneratedPassword on Linux and MacOS

TBR:kolos

Bug:  784861 
Change-Id: I680fdee98444aa62eb0954254a3d138088632bed
Reviewed-on: https://chromium-review.googlesource.com/773023
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516837}
[modify] https://crrev.com/47be7de585bb807028571c4bc9d2507d853e58bb/chrome/browser/password_manager/password_generation_interactive_uitest.cc

Comment 3 by kolos@chromium.org, Nov 16 2017

Components: UI>Browser>Passwords
Labels: -Sheriff-Chromium
Thanks for pointing out. 

I will consider adding after SimulateUserTypingInField the following code
chrome::FocusLocationBar(browser());
WaitForElementValue("username_field", "tempORARY");

as we do in PasswordManagerBrowserTestBase.UsernameChanged


Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf6f430037745598cb9b7b651e228c1dec0902f

commit 2cf6f430037745598cb9b7b651e228c1dec0902f
Author: Greg Thompson <grt@chromium.org>
Date: Mon Nov 27 11:59:48 2017

Disabling PasswordGenerationInteractiveTest.AutoSavingGeneratedPassword everywhere.

It failes on Windows the same way as other platforms.

BUG= 784861 
TBR=kolos@chromium.org
NOTRY=true

Change-Id: Ib61173674d4e05ca97625af87ca3a77adad0f209
Reviewed-on: https://chromium-review.googlesource.com/790292
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519282}
[modify] https://crrev.com/2cf6f430037745598cb9b7b651e228c1dec0902f/chrome/browser/password_manager/password_generation_interactive_uitest.cc

Comment 5 by kolos@chromium.org, Dec 1 2017

Status: Fixed (was: Assigned)

Sign in to add a comment