New issue
Advanced search Search tips

Issue 784859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

100kb regression in resource_sizes (MonochromePublic.apk) at 516149:516149

Project Member Reported by agrieve@chromium.org, Nov 14 2017

Issue description

Caused by "Oilpan: Add magic number to BasePage"
Commit: 99f46d3e60fcc50776619bc69b459e54f4ca8e2d

Link to size graph: https://chromeperf.appspot.com/report?sid=a097e74b1aa288511afb4cb616efe0f95ba4d347ad61d5e835072f23450938ba&num_points=10&rev=516149

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph, this is entirely from native code.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 14 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=784859

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3f570d200452077da51aba87d70a0d18302e90c984fca711678e3d4ffd88511b


Bot(s) for this bug's original alert(s):

Android Builder
Here's the result of tools/binary_size/diagnose_bloat.py --cloud $SHA:

5585 symbols added (+), 7255 changed (~), 0 removed (-), 822618 unchanged (not shown)
Of changed symbols, 10835 grew, 2005 shrank
Number of unique symbols 510683 -> 511650 (+967)
0 paths added, 0 removed, 1587 changed

Showing 12,840 symbols (aliases not grouped for diffs) with total pss: 95100 bytes
Histogram of symbols based on PSS:
    (-4096,-2048]: 1     (-16,-8]: 403   (-1,0): 311      [4,8): 1147     [64,128): 308
       (-128,-64]: 7      (-8,-4]: 294    (0,1): 4835    [8,16): 1597    [128,256): 56
        (-64,-32]: 21     (-4,-2]: 280    [1,2): 751    [16,32): 884     [256,512): 7
        (-32,-16]: 532    (-2,-1]: 156    [2,4): 623    [32,64): 625    [512,1024): 2
.text=91.3kb     .rodata=0 bytes    .data.rel.ro=1568 bytes .data=0 bytes    .bss=0 bytes    total=92.9kb
Number of unique paths: 1627

Section Legend: t=.text, r=.rodata, R=.data.rel.ro, d=.data, b=.bss
Index | Running Total | Section@Address | Δ PSS (Δ size_without_padding) | Path
------------------------------------------------------------
~ 0)      -2700 (-3.0%) t@Group      -2700 (0->0)       {{no path}}
               ** symbol gaps (count=9)
+ 1)      -1970 (-2.2%) t@0x1411d08  730 (0->728)       third_party/WebKit/Source/platform/plugins/PluginData.cpp
               std::__ndk1::__sort
~ 2)      -1298 (-1.4%) t@0x1b0c320  672 (852->1524)    third_party/WebKit/Source/core/css/SelectorChecker.cpp
               blink::SelectorChecker::MatchForRelation const
~ 3)       -884 (-1.0%) t@0x1fbecac  414 (682->1096)    third_party/WebKit/Source/modules/indexeddb/IDBKey.cpp
               std::__ndk1::__sort
~ 4)       -480 (-0.5%) t@0x1c4e0cc  404 (288->692)     third_party/WebKit/Source/core/html/HTMLCollection.cpp
               blink::HTMLCollection::TraverseForwardToOffset const
+ 5)        -84 (-0.1%) R@0x2d6aeb0  396 (0->396)       third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp
               blink::BaseTemporalInputType [vtable]
+ 6)        288 (0.3%)  R@0x2d72adc  372 (0->372)       third_party/WebKit/Source/core/html/forms/InputType.cpp
               blink::InputType [vtable]
~ 7)        628 (0.7%)  t@0x1c4dd38  340 (320->660)     third_party/WebKit/Source/core/html/HTMLCollection.cpp
               blink::HTMLCollection::TraverseToFirst const
~ 8)        956 (1.1%)  t@0x19817f0  328 (2096->2424)   blink/core/XPathGrammar.cpp
               xpathyyparse
~ 9)       1276 (1.4%)  t@0x1daaf28  320 (444->764)     third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp
               blink::SVGTextLayoutAttributesBuilder::FillCharacterDataMap
~ 10)      1508 (1.7%)  t@0x1f7af28  232 (108->340)     third_party/WebKit/Source/modules/cachestorage/Cache.cpp
               blink::Cache::put
+ 11)      1732 (1.9%)  R@0x2d72c50  224 (0->224)       third_party/WebKit/Source/core/html/forms/InputTypeView.cpp
               blink::InputTypeView [vtable]
+ 12)      1956 (2.2%)  R@0x2d72e4c  224 (0->224)       third_party/WebKit/Source/core/html/forms/KeyboardClickableInputTypeView.cpp
               blink::KeyboardClickableInputTypeView [vtable]
~ 13)      2176 (2.4%)  t@0x1cda560  220 (28->248)      third_party/WebKit/Source/core/input/GestureManager.cpp
               blink::GestureManager::GestureManager
~ 14)      2384 (2.7%)  t@0x1b31cd8  208 (596->804)     third_party/WebKit/Source/core/css/properties/CSSPropertyShapeUtils.cpp
               blink::CSSPropertyShapeUtils::ConsumeBasicShape
~ 15)      2592 (2.9%)  t@0x1b8427c  208 (236->444)     third_party/WebKit/Source/core/dom/NodeIterator.cpp
               blink::NodeIterator::UpdateForNodeRemoval const
~ 16)      2796 (3.1%)  t@0x1f53be8  204 (1188->1392)   third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
               blink::AXLayoutObject::ComputeAccessibilityIsIgnored const
~ 17)      3000 (3.4%)  t@0x1e7b288  204 (1080->1284)   third_party/WebKit/Source/core/xml/XPathStep.cpp
               blink::XPath::Step::NodesInAxis const
~ 18)      3192 (3.6%)  t@0x1bc9084  192 (580->772)     third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
               blink::StateTextWritingDirection
~ 19)      3380 (3.8%)  t@0x1abdc08  188 (1352->1540)   third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
               blink::CreateKeyframeEffectModel
~ 20)      3568 (4.0%)  t@0x1bda6b4  188 (860->1048)    third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
               blink::TextIteratorAlgorithm::Advance
~ 21)      3756 (4.2%)  t@0x1bdb744  188 (868->1056)    third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp
               blink::TextIteratorAlgorithm::Advance
~ 22)      3942 (4.4%)  t@0x1cae234  186 (78->264)      third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
               blink::HTMLConstructionSite::AttachLater
+ 23)      4126 (4.6%)  t@0x1b51730  184 (0->184)       third_party/WebKit/Source/core/dom/ContainerNode.cpp
               blink::DOMTreeMutationDetector::DOMTreeMutationDetector
~ 24)      4306 (4.8%)  t@0x1fceb9c  180 (900->1080)    third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
               blink::MediaControlsImpl::InitializeControls
~ 25)      4484 (5.0%)  t@0x1c4e3b4  178 (118->296)     third_party/WebKit/Source/core/html/HTMLCollection.cpp
               blink::HTMLCollection::TraverseBackwardToOffset const
~ 26)      4660 (5.2%)  t@0x1fa5064  176 (1296->1472)   third_party/WebKit/Source/modules/fetch/FetchManager.cpp
               blink::FetchManager::Loader::DidReceiveResponse
~ 27)      4836 (5.4%)  t@0x1bcfdd4  176 (3672->3848)   third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
               blink::ReplaceSelectionCommand::DoApply
~ 28)      5004 (5.6%)  t@0x1b294c4  168 (192->360)     third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
               blink::CSSPropertyParserHelpers::ConsumeGradientColorStops
+ 29)      5172 (5.8%)  R@0x2d4cc4c  168 (0->168)       third_party/WebKit/Source/core/css/cssom/CSSStyleImageValue.cpp

Comment 3 by keishi@chromium.org, Nov 15 2017

Status: Started (was: Assigned)
Reverted r516149
https://chromium-review.googlesource.com/c/chromium/src/+/770670
Status: Fixed (was: Started)

Sign in to add a comment