fake_cryptohome_client does not contain install attributes after restarting chrome |
|||
Issue descriptionChecking install attributes from places other than Chrome is hard.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956a8d2042d38bcda54d07243f127cca087e49ef commit 956a8d2042d38bcda54d07243f127cca087e49ef Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Nov 22 11:19:31 2017 Move install_attributes.proto into components/policy/proto Also makes fake_cryptohome_client loads install_attributes from the stub file. It's needed to use install_attributes in fake_authpolicy_client (which uses fake_cryptohome_client). After that would be landed we should point to different repo on the Chrome OS side for that file. TBR=mnissler@chromium.org Bug: 784858 Test: manual Change-Id: I1febe7c278a65ea6c8714875816c1f03e1d6b335 Reviewed-on: https://chromium-review.googlesource.com/768718 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#518604} [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/chrome/browser/chromeos/settings/install_attributes.cc [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/chrome/browser/chromeos/settings/install_attributes_unittest.cc [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/chromeos/dbus/fake_cryptohome_client.cc [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/chromeos/dbus/fake_cryptohome_client.h [modify] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/components/policy/proto/BUILD.gn [rename] https://crrev.com/956a8d2042d38bcda54d07243f127cca087e49ef/components/policy/proto/install_attributes.proto
,
Nov 22 2017
,
Apr 4 2018
This has apparently long been fixed as tests and enrollments are not facing any issue and as tested in M64.0.3282.190 10176.76.0 stable paine. |
|||
►
Sign in to add a comment |
|||
Comment 1 by rsorokin@chromium.org
, Nov 14 2017