New issue
Advanced search Search tips

Issue 784840 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Password Generation] Crash: the manual fallback for generation causes a crash if the password field didn't have focus

Project Member Reported by kolos@chromium.org, Nov 14 2017

Issue description

What steps will reproduce the problem?
(1) Visit a page with a password form (e.g. facebook.com)
(2) Make right click at password field of sign-up form (don't make left click before!) and press "Generated password"

What is the expected result?
Generation popup should be shown.

What happens instead?
renderer crashes. 

Received signal 11 SEGV_MAPERR 000000000020
#0 0x7f0b4a87709c base::debug::StackTrace::StackTrace()
#1 0x7f0b4a876c01 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f0b4a986330 <unknown>
#3 0x7f0b44852397 blink::Element::BoundsInViewport()
#4 0x7f0b48c418d4 content::RenderViewImpl::ElementBoundsInWindow()
#5 0x55672995b17b autofill::PasswordGenerationAgent::ShowGenerationPopup()
#6 0x556728561289 autofill::mojom::PasswordGenerationAgentStubDispatch::Accept()
#7 0x7f0b49cf8b37 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#8 0x7f0b49cf836b mojo::internal::MultiplexRouter::Accept()
#9 0x7f0b49cef222 mojo::Connector::ReadSingleMessage()
#10 0x7f0b49cef9b1 mojo::Connector::ReadAllAvailableMessages()
#11 0x7f0b49cbc97a mojo::SimpleWatcher::OnHandleReady()
#12 0x7f0b4a87794f base::debug::TaskAnnotator::RunTask()
#13 0x7f0b43af30c9 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#14 0x7f0b43af10a7 blink::scheduler::TaskQueueManager::DoWork()
#15 0x7f0b4a87794f base::debug::TaskAnnotator::RunTask()
#16 0x7f0b4a89ef57 base::MessageLoop::RunTask()
#17 0x7f0b4a89f548 base::MessageLoop::DoWork()
#18 0x7f0b4a8a022a base::MessagePumpDefault::Run()
#19 0x7f0b4a8c6c04 base::RunLoop::Run()
#20 0x7f0b48c59798 content::RendererMain()
#21 0x7f0b48d7ad51 content::RunZygote()
#22 0x7f0b48d7bf75 content::ContentMainRunnerImpl::Run()
#23 0x7f0b4ad6449f service_manager::Main()
#24 0x7f0b48d7aa81 content::ContentMain()
#25 0x55672830c1cc ChromeMain
#26 0x7f0b3f897f45 __libc_start_main
#27 0x55672830c02a _start
  r8: 0000000000000000  r9: 00007ffdcc191950 r10: 00001a3607a4e840 r11: 0000000000000000
 r12: 00001a3607bd7f00 r13: 00001a36083b1301 r14: 00001a3607bd7fa8 r15: 00007ffdcc191b10
  di: 0000000000000000  si: 00001a3607bd7f78  bp: 00007ffdcc191a60  bx: 0000000000000000
  dx: 0000000000000a9f  ax: 0000000000000000  cx: 00007f0b4936e228  sp: 00007ffdcc1919a0
  ip: 00007f0b44852397 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000020
[end of stack trace]
Calling _exit(1). Core file will not be generated.

 

Comment 1 by kolos@chromium.org, Nov 16 2017

Description: Show this description

Comment 2 by kolos@chromium.org, Nov 16 2017

Summary: [Password Generation] Crash: the manual fallback for generation causes a crash if the password field didn't have focus (was: [Password Generation] Generation popup is shown for wrong field)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18c0a4353857a83c54cb60ea2b1b32c9ee55f34c

commit 18c0a4353857a83c54cb60ea2b1b32c9ee55f34c
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Nov 17 15:48:42 2017

[Password Generation] Notify PasswordGenerationAgent about focus change when the user triggers the context menu

The generation agent tracks last password field that had focus. The field is used for user-triggered password generation. Before this CL, the generation agent wasn't notified about focus change when the user triggers the context menu (only when the user makes left click on the field). This CL propagates right click events to autofill.

Bug:  784840 
Change-Id: I31e1d793350f3bd9a6b8a3d61d9fcff6e61acdd8
Reviewed-on: https://chromium-review.googlesource.com/768811
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517403}
[modify] https://crrev.com/18c0a4353857a83c54cb60ea2b1b32c9ee55f34c/chrome/renderer/autofill/password_generation_agent_browsertest.cc
[modify] https://crrev.com/18c0a4353857a83c54cb60ea2b1b32c9ee55f34c/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/18c0a4353857a83c54cb60ea2b1b32c9ee55f34c/components/autofill/content/renderer/password_generation_agent.h
[modify] https://crrev.com/18c0a4353857a83c54cb60ea2b1b32c9ee55f34c/content/renderer/input/render_widget_input_handler.cc

Comment 4 by kolos@chromium.org, Nov 17 2017

Status: Fixed (was: Started)

Sign in to add a comment